linux-kernel - Re: [PATCH RESEND] EDAC/altera: Remove redundant error logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230321232148.GDZBo8DNnxBNmvOUhP@fat_crate.local>
Date:   Wed, 22 Mar 2023 00:21:48 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Deepak R Varma <drv@...lo.com>
Cc:     Dinh Nguyen <dinguyen@...nel.org>, Tony Luck <tony.luck@...el.com>,
        James Morse <james.morse@....com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Robert Richter <rric@...nel.org>, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Saurabh Singh Sengar <ssengar@...rosoft.com>,
        pk.drv@...n2204.myguest.virtualbox.org
Subject: Re: [PATCH RESEND] EDAC/altera: Remove redundant error logging

On Thu, Mar 02, 2023 at 12:43:31AM +0530, Deepak R Varma wrote:
> A call to platform_get_irq() already prints an error on failure within
> its own implementation. So printing another error based on its return
> value in the caller is redundant and should be removed. The clean up
> also makes if condition block braces unnecessary. Remove that as well.
> 
> Issue identified using platform_get_irq.cocci coccinelle semantic patch.
> 
> Signed-off-by: Deepak R Varma <drv@...lo.com>
> ---
> Note:
>    The change was compile tested only.
>    Resending the patch for a review and feedback.
>      
>  drivers/edac/altera_edac.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette