linux-kernel - Re: [PATCH] arm64: Support CMDLINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <730417dd-43b6-67f4-922a-97d2ceb298bc@arm.com>
Date:   Tue, 21 Mar 2023 09:24:02 +0530
From:   Anshuman Khandual <anshuman.khandual@....com>
To:     Chris Packham <chris.packham@...iedtelesis.co.nz>,
        catalin.marinas@....com, will@...nel.org
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: Support CMDLINE_EXTEND

Hello Chris,

On 3/21/23 02:44, Chris Packham wrote:
> Support extending the bootloader provided command line for arm64
> targets. This support is already present via generic DT/EFI code the
> only thing required is for the architecture to make it selectable.

Does this config really depend on given platform's active support or
it is just matter of selecting this for interested platforms ? Could
this config definition be unified in a single place i.e arch/Kconfig
and be selected (unconditionally or conditionally) on all subscribing
platforms. There seems to be a redundancy in defining the exact same
config the same way, on multiple platforms.

$git grep "config CMDLINE_EXTEND"

arch/arm/Kconfig:config CMDLINE_EXTEND
arch/loongarch/Kconfig:config CMDLINE_EXTEND
arch/powerpc/Kconfig:config CMDLINE_EXTEND
arch/riscv/Kconfig:config CMDLINE_EXTEND
arch/sh/Kconfig:config CMDLINE_EXTEND   

I guess this redundancy should be removed as a pre-requisite, before
enabling it on arm64 as proposed here, which in itself seems alright.

> 
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> ---
>  arch/arm64/Kconfig | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 1023e896d46b..3c837b085f21 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -2228,6 +2228,12 @@ config CMDLINE_FROM_BOOTLOADER
>  	  the boot loader doesn't provide any, the default kernel command
>  	  string provided in CMDLINE will be used.
>  
> +config CMDLINE_EXTEND
> +	bool "Extend bootloader kernel arguments"
> +	help
> +	  The command-line arguments provided by the boot loader will be
> +	  appended to the default kernel command string.
> +
>  config CMDLINE_FORCE
>  	bool "Always use the default kernel command string"
>  	help