linux-kernel - Re: [PATCH] net/net_failover: fix queue exceeding warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALs4sv2KkjwRrHTEhCneDmN0JJV-x5Db=+ApXOObLpOcPR0=1Q@mail.gmail.com>
Date:   Tue, 21 Mar 2023 10:41:52 +0530
From:   Pavan Chebbi <pavan.chebbi@...adcom.com>
To:     Faicker Mo <faicker.mo@...oud.cn>
Cc:     Sridhar Samudrala <sridhar.samudrala@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/net_failover: fix queue exceeding warning

On Tue, Mar 21, 2023 at 8:15 AM Faicker Mo <faicker.mo@...oud.cn> wrote:
>
> If the primary device queue number is bigger than the default 16,
> there is a warning about the queue exceeding when tx from the
> net_failover device.
>

Can you describe the issue more? If the net device has not implemented
its own selection then netdev_pick_tx should take care of the
real_num_tx_queues.
Is that not happening?

> Signed-off-by: Faicker Mo <faicker.mo@...oud.cn>
> ---
>  drivers/net/net_failover.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/net_failover.c b/drivers/net/net_failover.c
> index 7a28e082436e..d0c916a53d7c 100644
> --- a/drivers/net/net_failover.c
> +++ b/drivers/net/net_failover.c
> @@ -130,14 +130,10 @@ static u16 net_failover_select_queue(struct net_device *dev,
>                         txq = ops->ndo_select_queue(primary_dev, skb, sb_dev);
>                 else
>                         txq = netdev_pick_tx(primary_dev, skb, NULL);
> -
> -               qdisc_skb_cb(skb)->slave_dev_queue_mapping = skb->queue_mapping;
> -
> -               return txq;
> +       } else {
> +               txq = skb_rx_queue_recorded(skb) ? skb_get_rx_queue(skb) : 0;
>         }
>
> -       txq = skb_rx_queue_recorded(skb) ? skb_get_rx_queue(skb) : 0;
> -
>         /* Save the original txq to restore before passing to the driver */
>         qdisc_skb_cb(skb)->slave_dev_queue_mapping = skb->queue_mapping;
>
> --
> 2.39.1
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)