linux-kernel - Re: [PATCH v2 0/4] arm64: dts: ti: j7: Add device-tree nodes for MCSPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b651a7f5-3d61-fe8b-13b0-7f0caf0f21fd@ti.com>
Date:   Tue, 21 Mar 2023 13:02:55 +0530
From:   "J, KEERTHY" <j-keerthy@...com>
To:     Vaishnav Achath <vaishnav.a@...com>, <nm@...com>,
        <vigneshr@...com>, <kristo@...nel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <u-kumar1@...com>, <j-luthra@...com>
Subject: Re: [PATCH v2 0/4] arm64: dts: ti: j7: Add device-tree nodes for
 MCSPI



On 3/21/2023 12:24 PM, Vaishnav Achath wrote:
> This series adds device tree nodes for Multi Channel Serial Peripheral
> Interface (MCSPI) on J721E, J7200, J721S2 and J784S4 platforms. All the
> MCSPI instances are disabled by default and can be enabled through overlays
> as required, the changes were tested using spidev loopback test for all
> instances and the data verified only for main_spi4 which is connected
> internally as slave to mcu_spi2 for all existing J7 devices.
> 
> V1->V2:
>    * Address Nishanth's feedback, combine main, mcu domain
>    MCSPI node addition changes to single commit per SoC.

Vaishnav,


As per TRM "MCSPI4 is directly connected as a slave to MCU_MCSPI2 by 
default at power-up. MCSPI4 and MCU_MCSPI2 are not pinned out externally".

The above is applicable to J721e/J7200. Similar mapping might be 
existing for j721s2 & j784s4 as well. Add this information in
the commit log. Other than that For the series:

Reviewed-by: Keerthy <j-keerthy@...com>

Regards,
Keerthy

> 
> Vaishnav Achath (4):
>    arm64: dts: ti: k3-j721e: Add MCSPI nodes
>    arm64: dts: ti: k3-j7200: Add MCSPI nodes
>    arm64: dts: ti: k3-j721s2: Add MCSPI nodes
>    arm64: dts: ti: k3-j784s4: Add MCSPI nodes
> 
>   arch/arm64/boot/dts/ti/k3-j7200-main.dtsi     | 88 +++++++++++++++++++
>   .../boot/dts/ti/k3-j7200-mcu-wakeup.dtsi      | 33 +++++++
>   arch/arm64/boot/dts/ti/k3-j721e-main.dtsi     | 88 +++++++++++++++++++
>   .../boot/dts/ti/k3-j721e-mcu-wakeup.dtsi      | 33 +++++++
>   arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi    | 88 +++++++++++++++++++
>   .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi     | 33 +++++++
>   arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi    | 88 +++++++++++++++++++
>   .../boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi     | 33 +++++++
>   8 files changed, 484 insertions(+)
>