linux-kernel - Re: [PATCH] drm/gma500: remove unused gma_pipe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMeQTsZmJP-RCXfMcLntLx-M=-O=D=hAvu5kNVJWwUzG3Emm=g@mail.gmail.com>
Date:   Tue, 21 Mar 2023 09:20:36 +0100
From:   Patrik Jakobsson <patrik.r.jakobsson@...il.com>
To:     Tom Rix <trix@...hat.com>
Cc:     airlied@...il.com, daniel@...ll.ch, nathan@...nel.org,
        ndesaulniers@...gle.com, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] drm/gma500: remove unused gma_pipe_event function

On Sun, Mar 19, 2023 at 3:23 PM Tom Rix <trix@...hat.com> wrote:
>
> clang with W=1 reports
> drivers/gpu/drm/gma500/psb_irq.c:35:19: error: unused function
>   'gma_pipe_event' [-Werror,-Wunused-function]
> static inline u32 gma_pipe_event(int pipe)
>                   ^
> This function is not used, so remove it.
>
> Signed-off-by: Tom Rix <trix@...hat.com>

Applied to drm-misc-next

Thanks
Patrik

> ---
>  drivers/gpu/drm/gma500/psb_irq.c | 11 -----------
>  1 file changed, 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/psb_irq.c b/drivers/gpu/drm/gma500/psb_irq.c
> index d421031462df..343c51250207 100644
> --- a/drivers/gpu/drm/gma500/psb_irq.c
> +++ b/drivers/gpu/drm/gma500/psb_irq.c
> @@ -32,17 +32,6 @@ static inline u32 gma_pipestat(int pipe)
>         BUG();
>  }
>
> -static inline u32 gma_pipe_event(int pipe)
> -{
> -       if (pipe == 0)
> -               return _PSB_PIPEA_EVENT_FLAG;
> -       if (pipe == 1)
> -               return _MDFLD_PIPEB_EVENT_FLAG;
> -       if (pipe == 2)
> -               return _MDFLD_PIPEC_EVENT_FLAG;
> -       BUG();
> -}
> -
>  static inline u32 gma_pipeconf(int pipe)
>  {
>         if (pipe == 0)
> --
> 2.27.0
>