linux-kernel - Re: [PATCH 20/28] media: platform: jpeg: always reference OF data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <86431868-488b-4a72-944b-231b6d0382b0@app.fastmail.com>
Date:   Tue, 21 Mar 2023 09:11:36 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Krzysztof Kozlowski" <krzysztof.kozlowski@...aro.org>,
        "Joe Tessler" <jrt@...gle.com>,
        "Hans Verkuil" <hverkuil-cisco@...all.nl>,
        "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        "Neil Armstrong" <neil.armstrong@...aro.org>,
        "Kevin Hilman" <khilman@...libre.com>,
        "Jerome Brunet" <jbrunet@...libre.com>,
        "Martin Blumenstingl" <martin.blumenstingl@...glemail.com>,
        "Thierry Reding" <thierry.reding@...il.com>,
        "Jon Hunter" <jonathanh@...dia.com>,
        "Manivannan Sadhasivam" <mani@...nel.org>,
        "Michael Tretter" <m.tretter@...gutronix.de>,
        "Pengutronix Kernel Team" <kernel@...gutronix.de>,
        "Jacopo Mondi" <jacopo+renesas@...ndi.org>,
        "Kieran Bingham" <kieran.bingham+renesas@...asonboard.com>,
        "Laurent Pinchart" <laurent.pinchart+renesas@...asonboard.com>,
        Niklas Söderlund 
        <niklas.soderlund+renesas@...natech.se>,
        "Rui Miguel Silva" <rmfrfs@...il.com>,
        "Wenyou Yang" <wenyou.yang@...rochip.com>,
        "Bin Liu" <bin.liu@...iatek.com>,
        "Matthias Brugger" <matthias.bgg@...il.com>,
        "AngeloGioacchino Del Regno" 
        <angelogioacchino.delregno@...labora.com>,
        "Minghsiu Tsai" <minghsiu.tsai@...iatek.com>,
        "Houlong Wei" <houlong.wei@...iatek.com>,
        "Andrew-CT Chen" <andrew-ct.chen@...iatek.com>,
        "Andrzej Pietrasiewicz" <andrzejtp2010@...il.com>,
        "Jacek Anaszewski" <jacek.anaszewski@...il.com>,
        "Sylwester Nawrocki" <s.nawrocki@...sung.com>,
        "Patrice Chotard" <patrice.chotard@...s.st.com>,
        "Yong Deng" <yong.deng@...ewell.com>,
        "Paul Kocialkowski" <paul.kocialkowski@...tlin.com>,
        "Chen-Yu Tsai" <wens@...e.org>,
        "Jernej Skrabec" <jernej.skrabec@...il.com>,
        "Samuel Holland" <samuel@...lland.org>,
        Prabhakar <prabhakar.csengg@...il.com>,
        "Ezequiel Garcia" <ezequiel@...guardiasur.com.ar>,
        "Philipp Zabel" <p.zabel@...gutronix.de>,
        "Sean Young" <sean@...s.org>, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-tegra@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
        linux-rockchip@...ts.infradead.org,
        oushixiong <oushixiong@...inos.cn>
Subject: Re: [PATCH 20/28] media: platform: jpeg: always reference OF data

On Sun, Mar 12, 2023, at 14:13, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here).  This
> also fixes !CONFIG_OF error:
>
>   drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c:1890:38: error: 
> ‘mtk8195_jpegdec_drvdata’ defined but not used 
> [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

I see now that we both submitted the same patch, but now Hans
merged a worse fix [1] without a changelog text.

    Arnd

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=4ae47770d57bff01