linux-kernel - Re: [PATCH] ARM: mstar: remove unused config MACH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <59c05b36-3370-4d7b-b8cc-39d6dc36cdd0@app.fastmail.com>
Date:   Tue, 21 Mar 2023 10:30:21 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Daniel Palmer" <daniel@...ngy.jp>,
        "Lukas Bulwahn" <lukas.bulwahn@...il.com>
Cc:     "Romain Perier" <romain.perier@...il.com>,
        "Russell King" <linux@...linux.org.uk>, soc@...nel.org,
        linux-arm-kernel@...ts.infradead.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: mstar: remove unused config MACH_MERCURY

On Tue, Mar 21, 2023, at 09:33, Daniel Palmer wrote:
> Hi Lukas
>
> On Tue, 21 Mar 2023 at 12:38, Lukas Bulwahn <lukas.bulwahn@...il.com> wrote:
>>
>> Commit 312b62b6610c ("ARM: mstar: Add machine for MStar/Sigmastar Armv7
>> SoCs") adds the config MACH_INFINITY and MACH_MERCURY. The MACH_INFINITY
>> config is used in the gpio-msc313 driver, but the MACH_MERCURY config is
>> never used to configure anything in the kernel tree.
>>
>> Remove the unused config MACH_MERCURY.
>
> Because work is still on going to push that stuff.
>
> nak from me.

The symbol has been unused three year though, and will
show up every time someone runs a script to look for
orphaned Kconfig entries.

I'd still prefer removing it now and only bringing it
back when you actually add the code for it.

     Arnd