linux-kernel - Re: [PATCH v2] PCI: qcom: Add async probe support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Mar 2023 11:01:59 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc:     lpieralisi@...nel.org, kw@...ux.com, robh@...nel.org,
        andersson@...nel.org, konrad.dybcio@...aro.org,
        bhelgaas@...gle.com, linux-pci@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        johan+linaro@...nel.org, steev@...i.org
Subject: Re: [PATCH v2] PCI: qcom: Add async probe support

On Mon, Mar 20, 2023 at 12:16:44PM +0530, Manivannan Sadhasivam wrote:
> Qcom PCIe RC driver waits for the PHY link to be up during the probe. This
> consumes several milliseconds during boot. So add async probe support so
> that other drivers can load in parallel while this driver waits for the
> link to be up.

You're not really "adding support" for async probe as much as you are
enabling it by default. Perhaps you can clarify that in the commit
summary and commit message (e.g. by rephrasing as "prefer async probe").

> Suggested-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> ---
> 
> Changes in v2:
> 
> * Rebased on top of v6.3-rc1

With an updated commit message:

Reviewed-by: Johan Hovold <johan+linaro@...nel.org>
Tested-by: Johan Hovold <johan+linaro@...nel.org>

>  drivers/pci/controller/dwc/pcie-qcom.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
> index a232b04af048..4ca357be88e0 100644
> --- a/drivers/pci/controller/dwc/pcie-qcom.c
> +++ b/drivers/pci/controller/dwc/pcie-qcom.c
> @@ -1862,6 +1862,7 @@ static struct platform_driver qcom_pcie_driver = {
>  		.name = "qcom-pcie",
>  		.suppress_bind_attrs = true,
>  		.of_match_table = qcom_pcie_match,
> +		.probe_type = PROBE_PREFER_ASYNCHRONOUS,
>  	},
>  };
>  builtin_platform_driver(qcom_pcie_driver);

Johan