[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <PH0PR11MB75877482FC5A666FC795F0179D819@PH0PR11MB7587.namprd11.prod.outlook.com>
Date: Tue, 21 Mar 2023 10:17:46 +0000
From: "Sit, Michael Wei Hong" <michael.wei.hong.sit@...el.com>
To: Andrew Lunn <andrew@...n.ch>
CC: Giuseppe Cavallaro <peppe.cavallaro@...com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>,
"David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
"Jakub Kicinski" <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
"Ong, Boon Leong" <boon.leong.ong@...el.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-stm32@...md-mailman.stormreply.com"
<linux-stm32@...md-mailman.stormreply.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"Looi, Hong Aun" <hong.aun.looi@...el.com>,
"Voon, Weifeng" <weifeng.voon@...el.com>,
"Lai, Peter Jun Ann" <peter.jun.ann.lai@...el.com>
Subject: RE: [PATCH net v2 2/2] net: stmmac: move fixed-link support fixup
code
> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Saturday, March 18, 2023 4:03 AM
> To: Sit, Michael Wei Hong <michael.wei.hong.sit@...el.com>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>; Alexandre
> Torgue <alexandre.torgue@...s.st.com>; Jose Abreu
> <joabreu@...opsys.com>; David S . Miller
> <davem@...emloft.net>; Eric Dumazet
> <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>;
> Paolo Abeni <pabeni@...hat.com>; Maxime Coquelin
> <mcoquelin.stm32@...il.com>; Ong, Boon Leong
> <boon.leong.ong@...el.com>; netdev@...r.kernel.org; linux-
> stm32@...md-mailman.stormreply.com; linux-arm-
> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; Looi,
> Hong Aun <hong.aun.looi@...el.com>; Voon, Weifeng
> <weifeng.voon@...el.com>; Lai, Peter Jun Ann
> <peter.jun.ann.lai@...el.com>
> Subject: Re: [PATCH net v2 2/2] net: stmmac: move fixed-link
> support fixup code
>
> On Tue, Mar 14, 2023 at 03:02:08PM +0800, Michael Sit Wei Hong
> wrote:
> > xpcs_an_inband value is updated in the speed_mode_2500
> function which
> > turns on the xpcs_an_inband mode.
> >
> > Moving the fixed-link fixup code to right before phylink setup
> to
> > ensure no more fixup will affect the fixed-link mode
> configurations.
>
> Please could you explain why this is correct, when you could
> simple not set priv->plat->mdio_bus_data->xpcs_an_inband =
> true; in intel_speed_mode_2500()?
>
> This all seems like hacks, rather than a clean design.
>
> Andrew
Makes sense, will test out with your suggestion and submit
the changes in next version, will feedback if there is any
findings.
Powered by blists - more mailing lists