linux-kernel - Re: [PATCH] Staging: rtl8712: Remove redundant parentheses and improve macro definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 21 Mar 2023 11:49:47 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Inshal Khan <kziaul123@...il.com>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8712: Remove redundant parentheses and
 improve macro definition

On Tue, Mar 21, 2023 at 04:11:22PM +0530, Inshal Khan wrote:
> This commit simplifies the code in the ieee80211 and osdep_intf modules by
> removing unnecessary parentheses and improving the readability and avoiding
> any unexpected as well as operator preceedence side effects of RND4 macro.
> These changes improve the robustness of the driver and make it easier to
> maintain going forward.
> 
> Signed-off-by: Inshal Khan <kziaul123@...il.com>
> ---
>  drivers/staging/rtl8712/ieee80211.c  | 10 +++++-----
>  drivers/staging/rtl8712/osdep_intf.h |  5 ++++-
>  2 files changed, 9 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c
> index 7d8f1a29d18a..85e698c2126d 100644
> --- a/drivers/staging/rtl8712/ieee80211.c
> +++ b/drivers/staging/rtl8712/ieee80211.c
> @@ -63,8 +63,8 @@ uint r8712_is_cckrates_included(u8 *rate)
>  	u32 i = 0;
>  
>  	while (rate[i] != 0) {
> -		if ((((rate[i]) & 0x7f) == 2) || (((rate[i]) & 0x7f) == 4) ||
> -		    (((rate[i]) & 0x7f) == 11) || (((rate[i]) & 0x7f) == 22))
> +		if (((rate[i] & 0x7f) == 2) || ((rate[i] & 0x7f) == 4) ||
> +		    ((rate[i] & 0x7f) == 11) || ((rate[i] & 0x7f) == 22))
>  			return true;
>  		i++;
>  	}
> @@ -76,8 +76,8 @@ uint r8712_is_cckratesonly_included(u8 *rate)
>  	u32 i = 0;
>  
>  	while (rate[i] != 0) {
> -		if ((((rate[i]) & 0x7f) != 2) && (((rate[i]) & 0x7f) != 4) &&
> -		    (((rate[i]) & 0x7f) != 11)  && (((rate[i]) & 0x7f) != 22))
> +		if (((rate[i] & 0x7f) != 2) && ((rate[i] & 0x7f) != 4) &&
> +		    ((rate[i] & 0x7f) != 11)  && ((rate[i] & 0x7f) != 22))
>  			return false;
>  		i++;
>  	}
> @@ -147,7 +147,7 @@ static uint r8712_get_rateset_len(u8 *rateset)
>  	uint i = 0;
>  
>  	while (1) {
> -		if ((rateset[i]) == 0)
> +		if (rateset[i] == 0)
>  			break;
>  		if (i > 12)
>  			break;
> diff --git a/drivers/staging/rtl8712/osdep_intf.h b/drivers/staging/rtl8712/osdep_intf.h
> index 9e75116c987e..3d4f82cc60f9 100644
> --- a/drivers/staging/rtl8712/osdep_intf.h
> +++ b/drivers/staging/rtl8712/osdep_intf.h
> @@ -17,7 +17,10 @@
>  #include "osdep_service.h"
>  #include "drv_types.h"
>  
> -#define RND4(x)	(((x >> 2) + ((x & 3) != 0)) << 2)
> +#define RND4(x) ({ \
> +		typeof(x) _x = (x); \
> +		(((_x) + 3) & ~3); \
> +		})
>  
>  struct intf_priv {
>  	u8 *intf_dev;
> -- 
> 2.34.1
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did many different things all at once, making it difficult
  to review.  All Linux kernel patches need to only do one thing at a
  time.  If you need to do multiple things (such as clean up all coding
  style issues in a file/driver), do it in a sequence of patches, each
  one doing only one thing.  This will make it easier to review the
  patches to ensure that they are correct, and to help alleviate any
  merge issues that larger patches can cause.


If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot