lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230321111228.v4nml7vztoomsiu6@uda0497096>
Date:   Tue, 21 Mar 2023 16:42:28 +0530
From:   Jai Luthra <j-luthra@...com>
To:     Vaishnav Achath <vaishnav.a@...com>
CC:     <nm@...com>, <vigneshr@...com>, <kristo@...nel.org>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <j-keerthy@...com>, <u-kumar1@...com>
Subject: Re: [PATCH v3 1/4] arm64: dts: ti: k3-j721e: Add MCSPI nodes

Hi Vaishnav,

Thanks for the series.

On Mar 21, 2023 at 13:58:24 +0530, Vaishnav Achath wrote:
> J721E has 8 MCSPI instances in the main domain and 3 instances
> in the MCU domain. Add the DT nodes for all the 11 instances and
> keep them disabled. MAIN_MCSPI4 is connected as a slave to MCU_MCSPI2
> by default at power-up, MAIN_MCSPI4 and MCU_MCSPI2 are not pinned out
> externally.
> 
> Co-developed-by: Keerthy <j-keerthy@...com>
> Signed-off-by: Keerthy <j-keerthy@...com>
> Signed-off-by: Vaishnav Achath <vaishnav.a@...com>

Reviewed-by: Jai Luthra <j-luthra@...com>

> ---
> 
> V2->V3:
>  * Update commit message to mention internal MCSPI loopback.
> 
> V1->V2: 
>   * Combine main, mcu domain, MCSPI node addition changes
>   to single commit.
> 
>  arch/arm64/boot/dts/ti/k3-j721e-main.dtsi     | 88 +++++++++++++++++++
>  .../boot/dts/ti/k3-j721e-mcu-wakeup.dtsi      | 33 +++++++
>  2 files changed, 121 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> index bfa296dce3a3..a90f076776ce 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> @@ -2328,4 +2328,92 @@
>  		bosch,mram-cfg = <0x0 128 64 64 64 64 32 32>;
>  		status = "disabled";
>  	};
> +
> +	main_spi0: spi@...0000 {
> +		compatible = "ti,am654-mcspi","ti,omap4-mcspi";
> +		reg = <0x00 0x02100000 0x00 0x400>;
> +		interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		power-domains = <&k3_pds 266 TI_SCI_PD_EXCLUSIVE>;
> +		clocks = <&k3_clks 266 1>;
> +		status = "disabled";
> +	};
> +
> +	main_spi1: spi@...0000 {
> +		compatible = "ti,am654-mcspi","ti,omap4-mcspi";
> +		reg = <0x00 0x02110000 0x00 0x400>;
> +		interrupts = <GIC_SPI 185 IRQ_TYPE_LEVEL_HIGH>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		power-domains = <&k3_pds 267 TI_SCI_PD_EXCLUSIVE>;
> +		clocks = <&k3_clks 267 1>;
> +		status = "disabled";
> +	};
> +
> +	main_spi2: spi@...0000 {
> +		compatible = "ti,am654-mcspi","ti,omap4-mcspi";
> +		reg = <0x00 0x02120000 0x00 0x400>;
> +		interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		power-domains = <&k3_pds 268 TI_SCI_PD_EXCLUSIVE>;
> +		clocks = <&k3_clks 268 1>;
> +		status = "disabled";
> +	};
> +
> +	main_spi3: spi@...0000 {
> +		compatible = "ti,am654-mcspi","ti,omap4-mcspi";
> +		reg = <0x00 0x02130000 0x00 0x400>;
> +		interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		power-domains = <&k3_pds 269 TI_SCI_PD_EXCLUSIVE>;
> +		clocks = <&k3_clks 269 1>;
> +		status = "disabled";
> +	};
> +
> +	main_spi4: spi@...0000 {
> +		compatible = "ti,am654-mcspi","ti,omap4-mcspi";
> +		reg = <0x00 0x02140000 0x00 0x400>;
> +		interrupts = <GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		power-domains = <&k3_pds 270 TI_SCI_PD_EXCLUSIVE>;
> +		clocks = <&k3_clks 270 1>;
> +		status = "disabled";
> +	};
> +
> +	main_spi5: spi@...0000 {
> +		compatible = "ti,am654-mcspi","ti,omap4-mcspi";
> +		reg = <0x00 0x02150000 0x00 0x400>;
> +		interrupts = <GIC_SPI 189 IRQ_TYPE_LEVEL_HIGH>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		power-domains = <&k3_pds 271 TI_SCI_PD_EXCLUSIVE>;
> +		clocks = <&k3_clks 271 1>;
> +		status = "disabled";
> +	};
> +
> +	main_spi6: spi@...0000 {
> +		compatible = "ti,am654-mcspi","ti,omap4-mcspi";
> +		reg = <0x00 0x02160000 0x00 0x400>;
> +		interrupts = <GIC_SPI 190 IRQ_TYPE_LEVEL_HIGH>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		power-domains = <&k3_pds 272 TI_SCI_PD_EXCLUSIVE>;
> +		clocks = <&k3_clks 272 1>;
> +		status = "disabled";
> +	};
> +
> +	main_spi7: spi@...0000 {
> +		compatible = "ti,am654-mcspi","ti,omap4-mcspi";
> +		reg = <0x00 0x02170000 0x00 0x400>;
> +		interrupts = <GIC_SPI 191 IRQ_TYPE_LEVEL_HIGH>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		power-domains = <&k3_pds 273 TI_SCI_PD_EXCLUSIVE>;
> +		clocks = <&k3_clks 273 1>;
> +		status = "disabled";
> +	};
>  };
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> index 8ac78034d5d6..24e8125db8c4 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> @@ -425,4 +425,37 @@
>  		bosch,mram-cfg = <0x0 128 64 64 64 64 32 32>;
>  		status = "disabled";
>  	};
> +
> +	mcu_spi0: spi@...00000 {
> +		compatible = "ti,am654-mcspi", "ti,omap4-mcspi";
> +		reg = <0x00 0x040300000 0x00 0x400>;
> +		interrupts = <GIC_SPI 848 IRQ_TYPE_LEVEL_HIGH>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		power-domains = <&k3_pds 274 TI_SCI_PD_EXCLUSIVE>;
> +		clocks = <&k3_clks 274 0>;
> +		status = "disabled";
> +	};
> +
> +	mcu_spi1: spi@...10000 {
> +		compatible = "ti,am654-mcspi", "ti,omap4-mcspi";
> +		reg = <0x00 0x040310000 0x00 0x400>;
> +		interrupts = <GIC_SPI 849 IRQ_TYPE_LEVEL_HIGH>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		power-domains = <&k3_pds 275 TI_SCI_PD_EXCLUSIVE>;
> +		clocks = <&k3_clks 275 0>;
> +		status = "disabled";
> +	};
> +
> +	mcu_spi2: spi@...20000 {
> +		compatible = "ti,am654-mcspi", "ti,omap4-mcspi";
> +		reg = <0x00 0x040320000 0x00 0x400>;
> +		interrupts = <GIC_SPI 850 IRQ_TYPE_LEVEL_HIGH>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		power-domains = <&k3_pds 276 TI_SCI_PD_EXCLUSIVE>;
> +		clocks = <&k3_clks 276 0>;
> +		status = "disabled";
> +	};
>  };
> -- 
> 2.17.1
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ