[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZBmsXYV6jkLiFmJz@smile.fi.intel.com>
Date: Tue, 21 Mar 2023 15:08:45 +0200
From: "andriy.shevchenko@...ux.intel.com"
<andriy.shevchenko@...ux.intel.com>
To: "Winiarska, Iwona" <iwona.winiarska@...el.com>
Cc: "pmenzel@...gen.mpg.de" <pmenzel@...gen.mpg.de>,
"linux@...ck-us.net" <linux@...ck-us.net>,
"linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
"openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"jdelvare@...e.com" <jdelvare@...e.com>,
"fercerpav@...il.com" <fercerpav@...il.com>
Subject: Re: [PATCH] hwmon: (peci/cputemp) Fix miscalculated DTS for SKX
On Tue, Mar 21, 2023 at 10:29:22AM +0000, Winiarska, Iwona wrote:
> On Tue, 2023-03-21 at 10:41 +0100, Paul Menzel wrote:
> > Am 21.03.23 um 10:04 schrieb Iwona Winiarska:
...
> > This is not aligned. Why not only use one space before the equal sign?
>
> Yeah - same alignment problem is present in cpu_hsx and cpu_icx though, so I
> just followed along for skx to not stand out visually.
> So while I agree that alignment is broken here, I think it might be better to
> separate out the potential cleanup from the fix.
I agree with Iwona. If community wants a cleanup, it can be created in
a separate patch. For the fixes it's better to reduce the unrelated churn.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists