linux-kernel - Re: [PATCH] comedi: remove unused dma_chain_flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a0eb6753-a92f-70bc-7794-c58f8362b1a4@mev.co.uk>
Date:   Tue, 21 Mar 2023 14:18:05 +0000
From:   Ian Abbott <abbotti@....co.uk>
To:     Tom Rix <trix@...hat.com>, hsweeten@...ionengravers.com,
        nathan@...nel.org, ndesaulniers@...gle.com
Cc:     linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] comedi: remove unused dma_chain_flag_bits function

On 21/03/2023 12:14, Tom Rix wrote:
> clang with W=1 reports
> drivers/comedi/drivers/cb_pcidas64.c:377:28: error: unused function
>    'dma_chain_flag_bits' [-Werror,-Wunused-function]
> static inline unsigned int dma_chain_flag_bits(u16 prepost_bits)
>                             ^
> This function is not used, so remove it.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>   drivers/comedi/drivers/cb_pcidas64.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/comedi/drivers/cb_pcidas64.c b/drivers/comedi/drivers/cb_pcidas64.c
> index ca6038a25f26..59390b23fa81 100644
> --- a/drivers/comedi/drivers/cb_pcidas64.c
> +++ b/drivers/comedi/drivers/cb_pcidas64.c
> @@ -374,11 +374,6 @@ static inline u16 pipe_full_bits(u16 hw_status_bits)
>   	return (hw_status_bits >> 10) & 0x3;
>   };
>   
> -static inline unsigned int dma_chain_flag_bits(u16 prepost_bits)
> -{
> -	return (prepost_bits >> 6) & 0x3;
> -}
> -
>   static inline unsigned int adc_upper_read_ptr_code(u16 prepost_bits)
>   {
>   	return (prepost_bits >> 12) & 0x3;

Looks OK, thanks!

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott <abbotti@....co.uk> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-