linux-kernel - Re: [PATCH net-next] smsc911x: remove superfluous variable init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBnBZwC9WEoNK0Gp@ninjato>
Date:   Tue, 21 Mar 2023 15:38:31 +0100
From:   Wolfram Sang <wsa+renesas@...g-engineering.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        Steve Glendinning <steve.glendinning@...well.net>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] smsc911x: remove superfluous variable init


> >         struct smsc911x_data *pdata = netdev_priv(dev);
> > -       struct phy_device *phydev = NULL;
> > +       struct phy_device *phydev;
> >         int ret;
> >
> >         phydev = phy_find_first(pdata->mii_bus);
> 
> Nit: perhaps combine this assignment with the variable declaration?

I thought about it but found this version to be easier readable.

Thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)