[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d30ea7f5-7b47-474f-8208-a87d0b2e1394@roeck-us.net>
Date: Tue, 21 Mar 2023 07:42:24 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Iwona Winiarska <iwona.winiarska@...el.com>
Cc: linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
openbmc@...ts.ozlabs.org, Paul Fertser <fercerpav@...il.com>,
Jean Delvare <jdelvare@...e.com>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH] hwmon: (peci/cputemp) Fix miscalculated DTS for SKX
On Tue, Mar 21, 2023 at 10:04:10AM +0100, Iwona Winiarska wrote:
> For Skylake, DTS temperature of the CPU is reported in S10.6 format
> instead of S8.8.
>
> Reported-by: Paul Fertser <fercerpav@...il.com>
> Link: https://lore.kernel.org/lkml/ZBhHS7v+98NK56is@home.paul.comp/
> Signed-off-by: Iwona Winiarska <iwona.winiarska@...el.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/peci/cputemp.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/peci/cputemp.c b/drivers/hwmon/peci/cputemp.c
> index 30850a479f61..87d56f0fc888 100644
> --- a/drivers/hwmon/peci/cputemp.c
> +++ b/drivers/hwmon/peci/cputemp.c
> @@ -537,6 +537,12 @@ static const struct cpu_info cpu_hsx = {
> .thermal_margin_to_millidegree = &dts_eight_dot_eight_to_millidegree,
> };
>
> +static const struct cpu_info cpu_skx = {
> + .reg = &resolved_cores_reg_hsx,
> + .min_peci_revision = 0x33,
> + .thermal_margin_to_millidegree = &dts_ten_dot_six_to_millidegree,
> +};
> +
> static const struct cpu_info cpu_icx = {
> .reg = &resolved_cores_reg_icx,
> .min_peci_revision = 0x40,
> @@ -558,7 +564,7 @@ static const struct auxiliary_device_id peci_cputemp_ids[] = {
> },
> {
> .name = "peci_cpu.cputemp.skx",
> - .driver_data = (kernel_ulong_t)&cpu_hsx,
> + .driver_data = (kernel_ulong_t)&cpu_skx,
> },
> {
> .name = "peci_cpu.cputemp.icx",
Powered by blists - more mailing lists