linux-kernel - Re: [PATCH v1 1/1] scripts: merge_config: Fix typo in variable name.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c93723aa-f01c-9f1e-c9c7-aa79f38390c1@infradead.org>
Date:   Wed, 22 Mar 2023 08:20:58 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Mirsad Goran Todorovac <mirsad.todorovac@....unizg.hr>,
        Mark Brown <broonie@...nel.org>, linux-kbuild@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Masahiro Yamada <masahiroy@...nel.org>
Subject: Re: [PATCH v1 1/1] scripts: merge_config: Fix typo in variable name.



On 3/22/23 01:51, Mirsad Goran Todorovac wrote:
> ${WARNOVERRIDE} was misspelled as ${WARNOVVERIDE}, which caused a shell
> syntax error in certain paths of the script execution.
> 

Fixes: 46dff8d7e381e ("scripts: merge_config: Add option to suppress warning on overrides")

Acked-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> Cc: Mark Brown <broonie@...nel.org>
> Cc: Masahiro Yamada <masahiroy@...nel.org>
> Cc: linux-kbuild@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Signed-of-by: Mirsad Goran Todorovac <mirsad.todorovac@....unizg.hr>
> ---
>  scripts/kconfig/merge_config.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh
> index 32620de473ad..902eb429b9db 100755
> --- a/scripts/kconfig/merge_config.sh
> +++ b/scripts/kconfig/merge_config.sh
> @@ -145,7 +145,7 @@ for ORIG_MERGE_FILE in $MERGE_LIST ; do
>  		NEW_VAL=$(grep -w $CFG $MERGE_FILE)
>  		BUILTIN_FLAG=false
>  		if [ "$BUILTIN" = "true" ] && [ "${NEW_VAL#CONFIG_*=}" = "m" ] && [ "${PREV_VAL#CONFIG_*=}" = "y" ]; then
> -			${WARNOVVERIDE} Previous  value: $PREV_VAL
> +			${WARNOVERRIDE} Previous  value: $PREV_VAL
>  			${WARNOVERRIDE} New value:       $NEW_VAL
>  			${WARNOVERRIDE} -y passed, will not demote y to m
>  			${WARNOVERRIDE}

-- 
~Randy