linux-kernel - Re: [PATCH] gpio: pxa: remove unused gpio_is_pxa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MfMDLC1npyyjGe+Ph6fNwB_Wau7XDPMAnM-wPzec3_rfA@mail.gmail.com>
Date:   Wed, 22 Mar 2023 17:27:39 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Tom Rix <trix@...hat.com>
Cc:     robert.jarzmik@...e.fr, linus.walleij@...aro.org,
        nathan@...nel.org, ndesaulniers@...gle.com,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev
Subject: Re: [PATCH] gpio: pxa: remove unused gpio_is_pxa_type function

On Sun, Mar 19, 2023 at 3:36 PM Tom Rix <trix@...hat.com> wrote:
>
> clang with W=1 reports
> drivers/gpio/gpio-pxa.c:174:19: error: unused function
>   'gpio_is_pxa_type' [-Werror,-Wunused-function]
> static inline int gpio_is_pxa_type(int type)
>                   ^
> This function is not used, so remove it.
>
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/gpio/gpio-pxa.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
> index 1198ab0305d0..a1630ed4b741 100644
> --- a/drivers/gpio/gpio-pxa.c
> +++ b/drivers/gpio/gpio-pxa.c
> @@ -171,11 +171,6 @@ static inline struct pxa_gpio_bank *gpio_to_pxabank(struct gpio_chip *c,
>         return chip_to_pxachip(c)->banks + gpio / 32;
>  }
>
> -static inline int gpio_is_pxa_type(int type)
> -{
> -       return (type & MMP_GPIO) == 0;
> -}
> -
>  static inline int gpio_is_mmp_type(int type)
>  {
>         return (type & MMP_GPIO) != 0;
> --
> 2.27.0
>

Applied, thanks!

Bart