linux-kernel - Re: [PATCH net] net: enetc: fix aggregate RMON counters not showing the ranges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230322165126.23bwb4rnnbuuwlnx@skbuf>
Date:   Wed, 22 Mar 2023 18:51:26 +0200
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Simon Horman <simon.horman@...igine.com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: enetc: fix aggregate RMON counters not showing
 the ranges

On Wed, Mar 22, 2023 at 05:46:53PM +0100, Simon Horman wrote:
> This feels a bit more like an enhancement than a fix to me,
> but I don't feel strongly about it.

How so?

Since commit 38b922c91227 ("net: enetc: expose some standardized ethtool
counters") - merged in kernel v6.1 - the user could run this command and
see this output:

$ ethtool -S eno0 --groups rmon
Standard stats for eno0:
rmon-etherStatsUndersizePkts: 0
rmon-etherStatsOversizePkts: 0
rmon-etherStatsFragments: 0
rmon-etherStatsJabbers: 0
rx-rmon-etherStatsPkts64to64Octets: 0
rx-rmon-etherStatsPkts65to127Octets: 0
rx-rmon-etherStatsPkts128to255Octets: 0
rx-rmon-etherStatsPkts256to511Octets: 0
rx-rmon-etherStatsPkts512to1023Octets: 0
rx-rmon-etherStatsPkts1024to1522Octets: 0
rx-rmon-etherStatsPkts1523to9600Octets: 0
tx-rmon-etherStatsPkts64to64Octets: 0
tx-rmon-etherStatsPkts65to127Octets: 0
tx-rmon-etherStatsPkts128to255Octets: 0
tx-rmon-etherStatsPkts256to511Octets: 0
tx-rmon-etherStatsPkts512to1023Octets: 0
tx-rmon-etherStatsPkts1024to1522Octets: 0
tx-rmon-etherStatsPkts1523to9600Octets: 0

After the blamed commit - merged in the v6.3 release candidates - the
same command produces the following output:

$ ethtool -S eno0 --groups rmon
Standard stats for eno0:
rmon-etherStatsUndersizePkts: 0
rmon-etherStatsOversizePkts: 0
rmon-etherStatsFragments: 0
rmon-etherStatsJabbers: 0

So why is this an enhancement?