lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAMRc=MeDZVLmj9+sBQngbqr25HmX0O1BCEohOyij0SOhY_cwgg@mail.gmail.com> Date: Wed, 22 Mar 2023 17:55:39 +0100 From: Bartosz Golaszewski <brgl@...ev.pl> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Cc: William Breathitt Gray <william.gray@...aro.org>, Mark Brown <broonie@...nel.org>, Linus Walleij <linus.walleij@...aro.org>, linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org Subject: Re: [PATCH v3 0/2] Drop map from handle_mask_sync() parameters On Mon, Mar 20, 2023 at 4:32 PM Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote: > > On Mon, Mar 20, 2023 at 10:50:14AM -0400, William Breathitt Gray wrote: > > Changes in v3: > > - Inline dio48gpio->map usage in dio48e_handle_mask_sync() to avoid > > redefining map parameter > > > > Remove the map parameter from the struct regmap_irq_chip callback > > handle_mask_sync() because it can be passed via the irq_drv_data > > parameter instead. The gpio-104-dio-48e driver is the only consumer of > > this callback and is thus updated accordingly. > > > > A couple pending patchsets also utilize handle_mask_sync() [0][1], so > > it'll be useful to merge the changes in this series first to avoid > > subsequent noise adjusting the dependent drivers. > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> > > I believe this should go to the immutable branch somewhere, so GPIO and regmap > subsystems can pull from. > > > [0] https://lore.kernel.org/r/cover.1677515341.git.william.gray@linaro.org/ > > [1] https://lore.kernel.org/r/cover.1678106722.git.william.gray@linaro.org/ > > > > William Breathitt Gray (2): > > gpio: 104-dio-48e: Implement struct dio48e_gpio > > regmap-irq: Drop map from handle_mask_sync() parameters > > > > drivers/base/regmap/regmap-irq.c | 5 ++--- > > drivers/gpio/gpio-104-dio-48e.c | 37 +++++++++++++++++++++----------- > > include/linux/regmap.h | 3 +-- > > 3 files changed, 28 insertions(+), 17 deletions(-) > > > > > > base-commit: 03810031c91dfe448cd116ee987d5dc4139006f4 > > -- > > 2.39.2 > > > > -- > With Best Regards, > Andy Shevchenko > > Since patch 2/2 touches both GPIO and regmap, ideally I would get an Ack from Mark and take it through GPIO tree and then possibly provide Mark with a tag. Bart
Powered by blists - more mailing lists