linux-kernel - Re: [PATCH] loongarch: drop ranges for definition of ARCH_FORCE_MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f2729e78-bb8b-b1b7-7a5e-0e7d5075d33c@redhat.com>
Date:   Wed, 22 Mar 2023 18:14:55 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Mike Rapoport <rppt@...nel.org>,
        Huacai Chen <chenhuacai@...nel.org>,
        WANG Xuerui <kernel@...0n.name>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        "Kirill A. Shutemov" <kirill@...temov.name>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-mips@...r.kernel.org
Subject: Re: [PATCH] loongarch: drop ranges for definition of
 ARCH_FORCE_MAX_ORDER

On 22.03.23 09:17, Mike Rapoport wrote:
> From: "Mike Rapoport (IBM)" <rppt@...nel.org>
> 
> LoongArch defines insane ranges for ARCH_FORCE_MAX_ORDER allowing
> MAX_ORDER up to 63, which implies maximal contiguous allocation size of
> 2^63 pages.
> 
> Drop bogus definitions of ranges for ARCH_FORCE_MAX_ORDER and leave it a
> simple integer with sensible defaults.
> 
> Users that *really* need to change the value of ARCH_FORCE_MAX_ORDER
> will be able to do so but they won't be mislead by the bogus ranges.
> 
> Signed-off-by: Mike Rapoport (IBM) <rppt@...nel.org>
> ---
> 
> This applies to akpm/mm-unstable tree
> 
>   arch/loongarch/Kconfig | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
> index 272a3a12c98d..e1e3a3828962 100644
> --- a/arch/loongarch/Kconfig
> +++ b/arch/loongarch/Kconfig
> @@ -420,11 +420,8 @@ config NODES_SHIFT
>   
>   config ARCH_FORCE_MAX_ORDER
>   	int "Maximum zone order"
> -	range 13 63 if PAGE_SIZE_64KB
>   	default "13" if PAGE_SIZE_64KB
> -	range 11 63 if PAGE_SIZE_16KB
>   	default "11" if PAGE_SIZE_16KB
> -	range 10 63
>   	default "10"
>   	help
>   	  The kernel memory allocator divides physically contiguous memory

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb