[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1a2278c5-5398-2e7a-344d-fd5dd9703b10@gmail.com>
Date: Wed, 22 Mar 2023 10:35:04 +0700
From: Bagas Sanjaya <bagasdotme@...il.com>
To: David Wang <00107082@....com>
Cc: linux-kernel@...r.kernel.org, masahiroy@...nel.org
Subject: Re: [PATCH] scripts/package: add back 'version' for builddeb
On 3/21/23 22:20, David Wang wrote:
>
>>
>> Again, your patch looks like corrupted (tabs converted to spaces).
>> Please resubmit; this time; generate the patch via git-format-patch(1)
>> and then send the resulting patch with git-send-email(1).
>>
>> Thanks.
>>
> I did use `git format-patch` and `git send-email`, but I did not run scripts/checkpatch.pl.
> Now when I run scripts/checkpatch.pl against the file generated by `git format-patch`, it shows a warning about "Fixes:" tag, and
> I have resend a patch which pass the checks of scripts/checkpatch.pl, hope this time it could be ok.
>
> ```
> $ scripts/checkpatch.pl 0001-scripts-package-add-back-version-for-builddeb.patch
> total: 0 errors, 0 warnings, 7 lines checked
>
> 0001-scripts-package-add-back-version-for-builddeb.patch has no obvious style problems and is ready for submission.
> ```
>
>
> David
OK, but there is already the similar fix submitted at [1]. Please test it.
Thanks anyway.
[1]: https://lore.kernel.org/linux-kbuild/3351f907cfd0b5d8372e858a8ec9065cc2bd91df.1679434718.git.kevin@kevinlocke.name/
--
An old man doll... just what I always wanted! - Clara
Powered by blists - more mailing lists