linux-kernel - Re: [PATCH net-next] net: ipa: add IPA v5.0 to ipa_version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBtrfLOh3EKBKW+F@corigine.com>
Date:   Wed, 22 Mar 2023 21:56:28 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Alex Elder <elder@...aro.org>
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, caleb.connolly@...aro.org, mka@...omium.org,
        evgreen@...omium.org, andersson@...nel.org,
        quic_cpratapa@...cinc.com, quic_avuyyuru@...cinc.com,
        quic_jponduru@...cinc.com, quic_subashab@...cinc.com,
        elder@...nel.org, netdev@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: ipa: add IPA v5.0 to ipa_version_string()

On Wed, Mar 22, 2023 at 09:47:42AM -0500, Alex Elder wrote:
> In the IPA device sysfs directory, the "version" file can be read to
> find out what IPA version is implemented.  The content of this file
> is supplied by ipa_version_string(), which needs to be updated to
> properly handle IPA v5.0.
> 
> Signed-off-by: Alex Elder <elder@...aro.org>

Hi Alex,

this patch looks fine. But I am curious.
Should IPA_VERSION_5_1 and IPA_VERSION_5_5 also be added?

> ---
> This should have been included in the previous series...
> 
>  drivers/net/ipa/ipa_sysfs.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ipa/ipa_sysfs.c b/drivers/net/ipa/ipa_sysfs.c
> index 14bd2f9030453..2ff09ce343b73 100644
> --- a/drivers/net/ipa/ipa_sysfs.c
> +++ b/drivers/net/ipa/ipa_sysfs.c
> @@ -36,6 +36,8 @@ static const char *ipa_version_string(struct ipa *ipa)
>  		return "4.9";
>  	case IPA_VERSION_4_11:
>  		return "4.11";
> +	case IPA_VERSION_5_0:
> +		return "5.0";
>  	default:
>  		return "0.0";	/* Won't happen (checked at probe time) */
>  	}
> -- 
> 2.34.1
>