linux-kernel - Re: [PATCH linux-next V2] dt-bindings: usb: snps,dwc3: correct i.MX8MQ support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12e898d4-e83a-3f08-53bd-f4990af97104@linaro.org>
Date:   Wed, 22 Mar 2023 23:04:20 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     "Peng Fan (OSS)" <peng.fan@....nxp.com>,
        gregkh@...uxfoundation.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, shawnguo@...nel.org,
        s.hauer@...gutronix.de, xu.yang_2@....com
Cc:     kernel@...gutronix.de, festevam@...il.com, linux-imx@....com,
        linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        jun.li@....com, Peng Fan <peng.fan@....com>
Subject: Re: [PATCH linux-next V2] dt-bindings: usb: snps,dwc3: correct
 i.MX8MQ support

On 22/03/2023 13:56, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@....com>
> 
> The previous i.MX8MQ support breaks rockchip,dwc3 support,
> so use select to restrict i.MX8MQ support and avoid break others.
> 
> Fixes: 3754c41c7686 ("dt-bindings: usb: snps,dwc3: support i.MX8MQ")
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
> 
> V2:
>  Add a new yaml file for i.MX8MQ DWC3. I am not sure whether this is right,
>  still meet dtbs error:
>  arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb: usb@...00000:
>  Unevaluated properties are not allowed ('phys', 'phy-names', 'maximum-speed'
>  were unexpected)
>  But there is already ref to snps,dwc3.yaml and dwc3 yaml ref to usb-x.yaml

Because your DTS has invalid properties, like usb3-resume-missing-cas
and others. Drop all properties which are not allowed by snps,dwc3.yaml.

Best regards,
Krzysztof