linux-kernel - Re: [PATCH] module/decompress: Never use kunmap() for local un-mappings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167952705567.2263470.18228933182686895553.b4-ty@kernel.org>
Date:   Wed, 22 Mar 2023 16:24:33 -0700
From:   Luis Chamberlain <mcgrof@...badil.infradead.org>
To:     jason.wessel@...driver.com, joe.lawrence@...hat.com,
        daniel.thompson@...aro.org, jikos@...nel.org,
        linux-modules@...r.kernel.org, llvm@...ts.linux.dev,
        nathan@...nel.org, trix@...hat.com, chris@...isdown.name,
        linux-kernel@...r.kernel.org, mbenes@...e.cz, terrelln@...com,
        kgdb-bugreport@...ts.sourceforge.net,
        live-patching@...r.kernel.org, fmdefrancesco@...il.com,
        dianders@...omium.org, pmladek@...e.com, jpoimboe@...nel.org,
        ndesaulniers@...gle.com, bpf@...r.kernel.org
Cc:     Luis Chamberlain <mcgrof@...nel.org>, ira.weiny@...el.com,
        dmitry.torokhov@...il.com, swboyd@...omium.org,
        piotrgorski@...hyos.org
Subject: Re: [PATCH] module/decompress: Never use kunmap() for local un-mappings

From: Luis Chamberlain <mcgrof@...nel.org>

On Wed, 15 Mar 2023 13:52:56 +0100, Fabio M. De Francesco wrote:
> Use kunmap_local() to unmap pages locally mapped with kmap_local_page().
> 
> kunmap_local() must be called on the kernel virtual address returned by
> kmap_local_page(), differently from how we use kunmap() which instead
> expects the mapped page as its argument.
> 
> In module_zstd_decompress() we currently map with kmap_local_page() and
> unmap with kunmap(). This breaks the code and so it should be fixed.
> 
> [...]

Applied, thanks!

[1/1] module/decompress: Never use kunmap() for local un-mappings
      commit: 3c17655ab13704582fe25e8ea3200a9b2f8bf20a

  Luis