linux-kernel - Re: [PATCH 1/2] initramfs: Check negative timestamp to prevent broken cpio archive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d909e0b1a9155112feb72b1f99c9fc4fc2d4263.camel@linux.ibm.com>
Date:   Wed, 22 Mar 2023 15:29:07 +1100
From:   Andrew Donnellan <ajd@...ux.ibm.com>
To:     Benjamin Gray <bgray@...ux.ibm.com>, linux-kernel@...r.kernel.org,
        linux-kbuild@...r.kernel.org
Subject: Re: [PATCH 1/2] initramfs: Check negative timestamp to prevent
 broken cpio archive

On Mon, 2023-03-20 at 15:08 +1100, Benjamin Gray wrote:
> Similar to commit 4c9d410f32b3 ("initramfs: Check timestamp to
> prevent
> broken cpio archive"), except asserts that the timestamp is
> non-negative. This can happen when the KBUILD_BUILD_TIMESTAMP is a
> value
> before UNIX epoch, which may be set when making reproducible builds
> that
> don't want to look like they use a valid date.
> 
> While support for dates before 1970 might not be supported, this is
> more
> about preventing undetected CPIO corruption. The printf's use a
> minimum
> length format specifier, and will happily make the field longer than
> 8
> characters if they need to.
> 
> Signed-off-by: Benjamin Gray <bgray@...ux.ibm.com>

Reviewed-by: Andrew Donnellan <ajd@...ux.ibm.com>
Tested-by: Andrew Donnellan <ajd@...ux.ibm.com>


-- 
Andrew Donnellan    OzLabs, ADL Canberra
ajd@...ux.ibm.com   IBM Australia Limited