linux-kernel - Re: [PATCH 3/3] dt-bindings: mfd: qcom,spmi-pmic: add nvram function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBqq2sIcjLenI/Az@hovoldconsulting.com>
Date:   Wed, 22 Mar 2023 08:14:34 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Rob Herring <robh+dt@...nel.org>
Cc:     Johan Hovold <johan+linaro@...nel.org>, devicetree@...r.kernel.org,
        Bjorn Andersson <andersson@...nel.org>,
        linux-kernel@...r.kernel.org,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        linux-arm-msm@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Lee Jones <lee@...nel.org>
Subject: Re: [PATCH 3/3] dt-bindings: mfd: qcom,spmi-pmic: add nvram function

On Tue, Mar 21, 2023 at 10:27:55AM -0500, Rob Herring wrote:
> On Tue, Mar 21, 2023 at 8:37 AM Johan Hovold <johan@...nel.org> wrote:
> > On Tue, Mar 21, 2023 at 08:20:55AM -0500, Rob Herring wrote:
> > > On Tue, Mar 21, 2023 at 8:17 AM Rob Herring <robh@...nel.org> wrote:
> > > > On Mon, 20 Mar 2023 14:57:10 +0100, Johan Hovold wrote:
> > > > > Add an 'nvram' pattern property and a reference to the corresponding
> > > > > SDAM DT schema.
> > > > >
> > > > > Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> > > > > ---
> > > > >  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++++
> > > > >  1 file changed, 4 insertions(+)
> > > >
> > > > Running 'make dtbs_check' with the schema in this patch gives the
> > > > following warnings. Consider if they are expected or the schema is
> > > > incorrect. These may not be new warnings.
> > > >
> > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > > > This will change in the future.
> > > >
> > > > Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230320135710.1989-4-johan+linaro@kernel.org
> > > >
> > >
> > > This is a long list of warnings. Can you all fix some of them before
> > > adding on to this binding.
> >
> > Note that this patch is only making the list of warnings shorter so I
> > don't think addressing the remaining issues should block this one.
> 
> How can you tell sorting thru the 100s of warnings? It sounded like a
> new feature to me, not a fix for something missing. Anyways, I've
> gotten 2 patches today for this binding and I don't see patches for
> fixes. Which is a bit surprising because you all generally are fixing
> warnings on the QCom stuff.

Indeed, it was not obvious and that's why I mentioned it.

The SDAM binding has been there since 2020 and 9664a6b54c57
("dt-bindings: nvmem: add binding for QTI SPMI SDAM") but updating the
"parent" pmic binding was apparently overlooked.

I'm generally not cleaning up DT checker warnings, but I want to avoid
adding new ones as I unknowingly did in this case when enabling the RTC
on the X13s.

> I didn't really mean to block this one, but I don't really want to see more.

Understood.

Johan