[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <88a6856e-c766-d4a5-1882-5350fd0e248a@linaro.org>
Date: Wed, 22 Mar 2023 08:34:32 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Julien Panis <jpanis@...libre.com>, lee@...nel.org,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
corbet@....net, arnd@...db.de, gregkh@...uxfoundation.org,
derek.kiernan@...inx.com, dragan.cvetic@...inx.com
Cc: eric.auger@...hat.com, jgg@...pe.ca, razor@...ckwall.org,
stephen@...workplumber.org, davem@...emloft.net,
christian.koenig@....com, contact@...rsion.fr,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-doc@...r.kernel.org, sterzik@...com, u-kumar1@...com,
eblanc@...libre.com, jneanne@...libre.com
Subject: Re: [PATCH v3 1/4] dt-bindings: mfd: Add TI TPS6594 PMIC
On 21/03/2023 18:10, Julien Panis wrote:
> TPS6594 is a Power Management IC which provides regulators and others
> features like GPIOs, RTC, watchdog, ESMs (Error Signal Monitor), and
> PFSM (Pre-configurable Finite State Machine) managing the state of the
> device.
> TPS6594 is the super-set device while TPS6593 and LP8764X are derivatives.
>
> Signed-off-by: Julien Panis <jpanis@...libre.com>
> ---
> .../devicetree/bindings/mfd/ti,tps6594.yaml | 231 ++++++++++++++++++
> 1 file changed, 231 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/ti,tps6594.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/ti,tps6594.yaml b/Documentation/devicetree/bindings/mfd/ti,tps6594.yaml
> new file mode 100644
> index 000000000000..4e4565a68e40
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/ti,tps6594.yaml
> @@ -0,0 +1,231 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/ti,tps6594.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI TPS6594 Power Management Integrated Circuit
> +
> +maintainers:
> + - Julien Panis <jpanis@...libre.com>
> +
> +description:
> + TPS6594 is a Power Management IC which provides regulators and others
> + features like GPIOs, RTC, watchdog, ESMs (Error Signal Monitor), and
> + PFSM (Pre-configurable Finite State Machine) managing the state of the device.
> + TPS6594 is the super-set device while TPS6593 and LP8764X are derivatives.
> +
> +properties:
> + compatible:
> + enum:
> + - ti,lp8764x
Does x stand for a wildcard? If so, then fix it. Compatibles should be
specific.
> + - ti,tps6593
> + - ti,tps6594
> +
> + reg:
> + description: I2C slave address or SPI chip select number.
> + maxItems: 1
> +
> + ti,primary-pmic:
> + type: boolean
> + description: |
> + Identify the primary PMIC on SPMI bus.
> + A multi-PMIC synchronization scheme is implemented in the PMIC device
> + to synchronize the power state changes with other PMIC devices. This is
> + accomplished through a SPMI bus: the primary PMIC is the controller
> + device on the SPMI bus, and the secondary PMICs are the target devices
> + on the SPMI bus.
> +
> + system-power-controller: true
> +
> + gpio-controller: true
> +
> + '#gpio-cells':
> + const: 2
> + description: |
> + The first cell is the pin number, the second cell is used to specify flags.
> + See ../gpio/gpio.txt for more information.
> +
> + interrupts:
> + maxItems: 1
> +
> + ti,multi-phase-id:
> + description: |
> + Describes buck multi-phase configuration, if any. For instance, XY id means
> + that outputs of buck converters X and Y are combined in multi-phase mode.
> + $ref: /schemas/types.yaml#/definitions/uint32-array
No improvements here. As Rob pointed out, this looks like coupled
regulators.
Best regards,
Krzysztof
Powered by blists - more mailing lists