linux-kernel - Re: [PATCH v3 2/5] dt-bindings: trivial-devices: Add acbel,fsg032

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e4b135b-8cfe-f77c-1fe3-3dc62704f851@linaro.org>
Date:   Wed, 22 Mar 2023 08:43:38 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Lakshmi Yadlapati <lakshmiy@...ibm.com>, robh+dt@...nel.org,
        linux@...ck-us.net, jdelvare@...e.com,
        krzysztof.kozlowski+dt@...aro.org, joel@....id.au, andrew@...id.au,
        eajames@...ux.ibm.com
Cc:     linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v3 2/5] dt-bindings: trivial-devices: Add acbel,fsg032

On 21/03/2023 20:09, Lakshmi Yadlapati wrote:
> Add new Acbel FSG032 power supply to trivial devices.
> 
> Signed-off-by: Lakshmi Yadlapati <lakshmiy@...ibm.com>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 6f482a254a1d..6fbfa79de343 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -30,6 +30,8 @@ properties:
>      items:
>        - enum:
>              # SMBus/I2C Digital Temperature Sensor in 6-Pin SOT with SMBus Alert and Over Temperature Pin
> +            # Acbel fsg032 power supply
> +          - acbel,fsg032

No, still wrong. Open the file and look at the lines where you put the
code. It seems you add it in random places.

Best regards,
Krzysztof