linux-kernel - Re: [PATCH] ARM: npcm: remove select of non-existant ERRATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <59886f87-c277-5917-a521-5893ab75acee@molgen.mpg.de>
Date:   Wed, 22 Mar 2023 08:50:32 +0100
From:   Paul Menzel <pmenzel@...gen.mpg.de>
To:     Rouven Czerwinski <r.czerwinski@...gutronix.de>
Cc:     Avi Fishman <avifishman70@...il.com>,
        Tomer Maimon <tmaimon77@...il.com>,
        Tali Perry <tali.perry1@...il.com>,
        Patrick Venture <venture@...gle.com>,
        Nancy Yuen <yuenn@...gle.com>,
        Benjamin Fair <benjaminfair@...gle.com>,
        Russell King <linux@...linux.org.uk>, openbmc@...ts.ozlabs.org,
        linux-arm-kernel@...ts.infradead.org, kernel@...gutronix.de,
        linux-kernel@...r.kernel.org,
        Brendan Higgins <brendan.higgins@...ux.dev>
Subject: Re: [PATCH] ARM: npcm: remove select of non-existant ERRATA

Dear Rouven,


Thank you for your patch.

Am 16.03.23 um 21:47 schrieb Rouven Czerwinski:

There is a small typo in the commit message summary/title: 
non-exist*e*nt. Maybe also mention the errata number:

ARM: npcm: Remove select of non-existent ARM_ERRATA_794072

> config ARCH_NPCM7XX selects ARM_ERRATA_794072, however this config
> option does not exist since the workaround for the errata requires
> secure mode access which needs to be run by the bootloader or firmware
> since linux can't determine whether it is running in secure mode.

Please add a Fixes: tag.

> Signed-off-by: Rouven Czerwinski <r.czerwinski@...gutronix.de>
> ---
>   arch/arm/mach-npcm/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/mach-npcm/Kconfig b/arch/arm/mach-npcm/Kconfig
> index 63b42a19d1b8..d933e8abb50f 100644
> --- a/arch/arm/mach-npcm/Kconfig
> +++ b/arch/arm/mach-npcm/Kconfig
> @@ -30,7 +30,6 @@ config ARCH_NPCM7XX
>   	select ARM_ERRATA_764369 if SMP
>   	select ARM_ERRATA_720789
>   	select ARM_ERRATA_754322
> -	select ARM_ERRATA_794072
>   	select PL310_ERRATA_588369
>   	select PL310_ERRATA_727915
>   	select MFD_SYSCON

Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>


Kind regards,

Paul