linux-kernel - Re: BUG: scripts/kconfig/merge_config.sh: typo in variable name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <40379213-6283-4ac7-b761-244df5537e56@alu.unizg.hr>
Date:   Wed, 22 Mar 2023 09:57:36 +0100
From:   Mirsad Todorovac <mirsad.todorovac@....unizg.hr>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     linux-kbuild@...r.kernel.org, Mark Brown <broonie@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: BUG: scripts/kconfig/merge_config.sh: typo in variable name

On 3/22/23 04:40, Masahiro Yamada wrote:
> On Wed, Mar 22, 2023 at 5:14 AM Mirsad Goran Todorovac
> <mirsad.todorovac@....unizg.hr> wrote:
>>
>> On 3/21/2023 2:04 PM, Mirsad Goran Todorovac wrote:
>>> Hi all,
>>>
>>> There is a typo in variable name in scripts/kconfig/merge_config.sh, with the
>>> script returning:
>>>
>>> $ ./scripts/kconfig/merge_config.sh -y -m ../.config tools/testing/selftests/net/config
>>> ./scripts/kconfig/merge_config.sh: 148: ./scripts/kconfig/merge_config.sh: Previous: not found
>>>
>>> Problem is probably best explained by this diff:
>>>
>>> ---
>>> diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh
>>> index 32620de473ad..902eb429b9db 100755
>>> --- a/scripts/kconfig/merge_config.sh
>>> +++ b/scripts/kconfig/merge_config.sh
>>> @@ -145,7 +145,7 @@ for ORIG_MERGE_FILE in $MERGE_LIST ; do
>>>                   NEW_VAL=$(grep -w $CFG $MERGE_FILE)
>>>                   BUILTIN_FLAG=false
>>>                   if [ "$BUILTIN" = "true" ] && [ "${NEW_VAL#CONFIG_*=}" = "m" ] && [ "${PREV_VAL#CONFIG_*=}" = "y" ]; then
>>> -                       ${WARNOVVERIDE} Previous  value: $PREV_VAL
>>> +                       ${WARNOVERRIDE} Previous  value: $PREV_VAL
>>>                           ${WARNOVERRIDE} New value:       $NEW_VAL
>>>                           ${WARNOVERRIDE} -y passed, will not demote y to m
>>>                           ${WARNOVERRIDE}
>>>
>>> Hope this helps.
>>
>> P.S.
>>
>> Later I thought of searching the committer of the patch that introduced the change,
>> so I Cc:ed Mark.
>>
>> Best regards,
>> Mirsad
> 
> Good catch.

Thanks.

> Will you please send a patch with your signed-off?

Submitted. I hope I did it right this time.

Best regards,
Mirsad

-- 
Mirsad Goran Todorovac
Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu

System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb, Republic of Croatia