linux-kernel - Re: [PATCH] mips: drop ranges for definition of ARCH_FORCE_MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Mar 2023 09:59:53 +0100
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Mike Rapoport <rppt@...nel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Huacai Chen <chenhuacai@...nel.org>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        "Kirill A. Shutemov" <kirill@...temov.name>,
        WANG Xuerui <kernel@...0n.name>, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, linux-mips@...r.kernel.org
Subject: Re: [PATCH] mips: drop ranges for definition of ARCH_FORCE_MAX_ORDER

On Wed, Mar 22, 2023 at 10:15:20AM +0200, Mike Rapoport wrote:
> From: "Mike Rapoport (IBM)" <rppt@...nel.org>
> 
> MIPS defines insane ranges for ARCH_FORCE_MAX_ORDER allowing MAX_ORDER
> up to 63, which implies maximal contiguous allocation size of 2^63
> pages.
> 
> Drop bogus definitions of ranges for ARCH_FORCE_MAX_ORDER and leave it a
> simple integer with sensible defaults.
> 
> Users that *really* need to change the value of ARCH_FORCE_MAX_ORDER
> will be able to do so but they won't be mislead by the bogus ranges.
> 
> Signed-off-by: Mike Rapoport (IBM) <rppt@...nel.org>
> ---
>  arch/mips/Kconfig | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 3e8b765b8c7b..a0f6e9d0a561 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -2137,13 +2137,9 @@ endchoice
>  
>  config ARCH_FORCE_MAX_ORDER
>  	int "Maximum zone order"
> -	range 13 63 if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_64KB
>  	default "13" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_64KB
> -	range 12 63 if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_32KB
>  	default "12" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_32KB
> -	range 11 63 if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_16KB
>  	default "11" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_16KB
> -	range 0 63
>  	default "10"
>  	help
>  	  The kernel memory allocator divides physically contiguous memory
> -- 
> 2.35.1

Thank you for cleaning this up.

Acked-by: Thomas Bogendoerfer <tsbogend@...ha.franken.de>

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]