linux-kernel - Re: [PATCH] staging: greybus: remove unnecessary blank line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <369edb35-b93b-301c-fcef-8e64e5d4a122@inria.fr>
Date:   Wed, 22 Mar 2023 11:14:18 +0100 (CET)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Menna Mahmoud <eng.mennamahmoud.mm@...il.com>
cc:     gregkh@...uxfoundation.org, outreachy@...ts.linux.dev,
        johan@...nel.org, elder@...nel.org, vireshk@...nel.org,
        thierry.reding@...il.com, u.kleine-koenig@...gutronix.de,
        greybus-dev@...ts.linaro.org, linux-kernel@...r.kernel.org,
        linux-staging@...ts.linux.dev, linux-pwm@...r.kernel.org
Subject: Re: [PATCH] staging: greybus: remove unnecessary blank line



On Wed, 22 Mar 2023, Menna Mahmoud wrote:

> Remove unnecessary blank line before struct as reported
> by checkpatch:
>
> " CHECK: Please don't use multiple blank lines "

Since there is no vX indicator, one doesn't know that this replaces some
previous patches.

julia

>
> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@...il.com>
> ---
>  drivers/staging/greybus/greybus_authentication.h | 1 -
>  drivers/staging/greybus/pwm.c                    | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/greybus_authentication.h b/drivers/staging/greybus/greybus_authentication.h
> index 7edc7295b7ab..48b4a9794d3c 100644
> --- a/drivers/staging/greybus/greybus_authentication.h
> +++ b/drivers/staging/greybus/greybus_authentication.h
> @@ -41,7 +41,6 @@
>  #define CAP_AUTH_RESULT_CR_NO_KEY	0x03
>  #define CAP_AUTH_RESULT_CR_SIG_FAIL	0x04
>
> -
>  /* IOCTL support */
>  struct cap_ioc_get_endpoint_uid {
>  	__u8			uid[8];
> diff --git a/drivers/staging/greybus/pwm.c b/drivers/staging/greybus/pwm.c
> index 3fda172239d2..26d39e08c3b6 100644
> --- a/drivers/staging/greybus/pwm.c
> +++ b/drivers/staging/greybus/pwm.c
> @@ -24,7 +24,6 @@ struct gb_pwm_chip {
>  #define pwm_chip_to_gb_pwm_chip(chip) \
>  	container_of(chip, struct gb_pwm_chip, chip)
>
> -
>  static int gb_pwm_count_operation(struct gb_pwm_chip *pwmc)
>  {
>  	struct gb_pwm_count_response response;
> --
> 2.34.1
>
>
>