lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d651b66d-a33b-ead0-e41-aeb76f4523b6@linux.intel.com>
Date:   Wed, 22 Mar 2023 14:35:07 +0200 (EET)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Arnd Bergmann <arnd@...nel.org>
cc:     Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        Neeraj Sanjay Kale <neeraj.sanjaykale@....com>,
        Arnd Bergmann <arnd@...db.de>, linux-bluetooth@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Bluetooth: NXP: select CONFIG_CRC8

On Wed, 22 Mar 2023, Arnd Bergmann wrote:

> From: Arnd Bergmann <arnd@...db.de>
> 
> The driver needs both CRC32 and CRC8 to link correctly:
> 
> ld.lld: error: undefined symbol: crc8_populate_msb
> >>> referenced by btnxpuart.c
> >>>               drivers/bluetooth/btnxpuart.o:(nxp_serdev_probe) in archive vmlinux.a
> ld.lld: error: undefined symbol: crc8
> >>> referenced by btnxpuart.c
> >>>               drivers/bluetooth/btnxpuart.o:(nxp_send_ack) in archive vmlinux.a
> 
> Fixes: 3e662aa4453a ("Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/bluetooth/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
> index 0703bdd44140..f84322d375de 100644
> --- a/drivers/bluetooth/Kconfig
> +++ b/drivers/bluetooth/Kconfig
> @@ -469,6 +469,7 @@ config BT_NXPUART
>  	tristate "NXP protocol support"
>  	depends on SERIAL_DEV_BUS
>  	select CRC32
> +	select CRC8
>  	help
>  	  NXP is serial driver required for NXP Bluetooth
>  	  devices with UART interface.
> 

Right. ...I should have realized this was missing too when I noticed 
select CRC32 wasn't there.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>


-- 
 i.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ