linux-kernel - Re: [PATCH] dmaengine: tegra-apb: remove unused tdma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <85946aff-0cf7-62ca-60f6-e95c65b67e51@nvidia.com>
Date:   Wed, 22 Mar 2023 13:46:02 +0000
From:   Jon Hunter <jonathanh@...dia.com>
To:     Tom Rix <trix@...hat.com>, ldewangan@...dia.com, vkoul@...nel.org,
        thierry.reding@...il.com, nathan@...nel.org,
        ndesaulniers@...gle.com
Cc:     dmaengine@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] dmaengine: tegra-apb: remove unused tdma_read function



On 22/03/2023 12:10, Tom Rix wrote:
> clang with W=1 reports
> drivers/dma/tegra20-apb-dma.c:236:19: error: unused function
>    'tdma_read' [-Werror,-Wunused-function]
> static inline u32 tdma_read(struct tegra_dma *tdma, u32 reg)
>                    ^
> This function is not used so remove it.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>   drivers/dma/tegra20-apb-dma.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
> index eaafcbe4ca94..cc6b91f48979 100644
> --- a/drivers/dma/tegra20-apb-dma.c
> +++ b/drivers/dma/tegra20-apb-dma.c
> @@ -233,11 +233,6 @@ static inline void tdma_write(struct tegra_dma *tdma, u32 reg, u32 val)
>   	writel(val, tdma->base_addr + reg);
>   }
>   
> -static inline u32 tdma_read(struct tegra_dma *tdma, u32 reg)
> -{
> -	return readl(tdma->base_addr + reg);
> -}
> -
>   static inline void tdc_write(struct tegra_dma_channel *tdc,
>   			     u32 reg, u32 val)
>   {


Thanks!

Reviewed-by: Jon Hunter <jonathanh@...dia.com>

Jon

-- 
nvpublic