linux-kernel - RE: [EXT] Re: [PATCH v3 1/3] dt-bindings: usb: cdns-imx8qm: add imx8qm cdns3 glue bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM6PR04MB483828FC1083E3C98930DF6488869@AM6PR04MB4838.eurprd04.prod.outlook.com>
Date:   Wed, 22 Mar 2023 14:34:02 +0000
From:   Frank Li <frank.li@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
CC:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "festevam@...il.com" <festevam@...il.com>,
        "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        dl-linux-imx <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>
Subject: RE: [EXT] Re: [PATCH v3 1/3] dt-bindings: usb: cdns-imx8qm: add
 imx8qm cdns3 glue bindings



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Wednesday, March 22, 2023 2:32 AM
> To: Frank Li <frank.li@....
> > +      - const: usb3_aclk
> > +      - const: usb3_ipg_clk
> > +      - const: usb3_core_pclk
> > +
> > +  assigned-clocks:
> > +    items:
> > +      - description: Phandle and clock specifoer of
> IMX_SC_PM_CLK_MST_BUS.
> 
> Drop useless pieces so "Phandle and clock specifoer of " and name the
> hardware, not the syntax.
> 
> > +
> > +  assigned-clock-rates:
> > +    items:
> > +      - description: Should be in Range 100 - 600 Mhz.
> 
> That's better but I still do not understand why do you need it in the
> bindings. You never actually answered this question.

I am not sure 100% sure the reason. 
I think difference system target's  axi bus frequency is difference,   
And just one time work, needn't software to manage it.
Following other driver's code style may be another reason. 

> 
> Best regards,
> Krzysztof