linux-kernel - Re: [PATCH v2 01/14] mips: fix comment about pgtable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d7330917-730b-0219-979f-dd770ff0180f@linaro.org>
Date:   Wed, 22 Mar 2023 15:49:30 +0100
From:   Philippe Mathieu-Daudé <philmd@...aro.org>
To:     Mike Rapoport <rppt@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     David Hildenbrand <david@...hat.com>,
        Doug Berger <opendmb@...il.com>,
        Matthew Wilcox <willy@...radead.org>,
        Mel Gorman <mgorman@...e.de>, Michal Hocko <mhocko@...nel.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Vlastimil Babka <vbabka@...e.cz>, linux-kernel@...r.kernel.org,
        linux-mips@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v2 01/14] mips: fix comment about pgtable_init()

On 21/3/23 15:48, Mike Rapoport wrote:
> From: "Mike Rapoport (IBM)" <rppt@...nel.org>
> 
> Comment about fixrange_init() says that its called from pgtable_init()
> while the actual caller is pagetabe_init().
> 
> Update comment to match the code.
> 
> Signed-off-by: Mike Rapoport (IBM) <rppt@...nel.org>
> Reviewed-by: David Hildenbrand <david@...hat.com>
> ---
>   arch/mips/include/asm/fixmap.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/include/asm/fixmap.h b/arch/mips/include/asm/fixmap.h
> index beea14761cef..b037718d7e8b 100644
> --- a/arch/mips/include/asm/fixmap.h
> +++ b/arch/mips/include/asm/fixmap.h
> @@ -70,7 +70,7 @@ enum fixed_addresses {
>   #include <asm-generic/fixmap.h>
>   
>   /*
> - * Called from pgtable_init()
> + * Called from pagetable_init()

I'm not sure about the usefulness of this comment; I suppose it
predates git-grep. Anyhow,

Reviewed-by: Philippe Mathieu-Daudé <philmd@...aro.org>

>    */
>   extern void fixrange_init(unsigned long start, unsigned long end,
>   	pgd_t *pgd_base);