linux-kernel - Re: [PATCH] mtd: rawnand: mxc: Remove the unused function is_imx51

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230322155508.6f4acb80@xps-13>
Date:   Wed, 22 Mar 2023 15:55:08 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     richard@....at, vigneshr@...com, linux-mtd@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] mtd: rawnand: mxc: Remove the unused function
 is_imx51_nfc()

Hi,

jiapeng.chong@...ux.alibaba.com wrote on Fri, 17 Mar 2023 15:40:41
+0800:

> The function is_imx51_nfc is defined in the mxc_nand.c file, but not
> called elsewhere, so remove this unused function.
> 
> drivers/mtd/nand/raw/mxc_nand.c:1602:19: warning: unused function 'is_imx51_nfc'.

Thanks for your patch, but apparently is_imx53_nfc() is also unused,
strange the robot did not pick this up. Anyway, no need to resend, I
received another patch removing both functions already.

> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4559
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  drivers/mtd/nand/raw/mxc_nand.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/mxc_nand.c b/drivers/mtd/nand/raw/mxc_nand.c
> index f6c96341b896..16d795c25609 100644
> --- a/drivers/mtd/nand/raw/mxc_nand.c
> +++ b/drivers/mtd/nand/raw/mxc_nand.c
> @@ -1599,11 +1599,6 @@ static inline int is_imx25_nfc(struct mxc_nand_host *host)
>  	return host->devtype_data == &imx25_nand_devtype_data;
>  }
>  
> -static inline int is_imx51_nfc(struct mxc_nand_host *host)
> -{
> -	return host->devtype_data == &imx51_nand_devtype_data;
> -}
> -
>  static inline int is_imx53_nfc(struct mxc_nand_host *host)
>  {
>  	return host->devtype_data == &imx53_nand_devtype_data;


Thanks,
Miquèl