linux-kernel - Re: [PATCH net-next] smsc911x: remove superfluous variable init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <65d770947b98805a52573b3fa2df11f5d1778af7.camel@redhat.com>
Date:   Wed, 22 Mar 2023 15:58:40 +0100
From:   Paolo Abeni <pabeni@...hat.com>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        Steve Glendinning <steve.glendinning@...well.net>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] smsc911x: remove superfluous variable init

On Tue, 2023-03-21 at 15:38 +0100, Wolfram Sang wrote:
> > >         struct smsc911x_data *pdata = netdev_priv(dev);
> > > -       struct phy_device *phydev = NULL;
> > > +       struct phy_device *phydev;
> > >         int ret;
> > > 
> > >         phydev = phy_find_first(pdata->mii_bus);
> > 
> > Nit: perhaps combine this assignment with the variable declaration?
> 
> I thought about it but found this version to be easier readable.

This patch does not apply cleanly to net-next, please rebase and
resping.

Thanks!

Paolo