linux-kernel - Re: [PATCH v2] usb: dwc3: host: remove dead code in dwc3_host_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Mar 2023 16:38:24 +0100
From:   Oliver Neukum <oneukum@...e.com>
To:     Dan Carpenter <error27@...il.com>, Oliver Neukum <oneukum@...e.com>
Cc:     Sergei Shtylyov <sergei.shtylyov@...il.com>,
        Mingxuan Xiang <mx_xiang@...t.edu.cn>,
        Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        hust-os-kernel-patches@...glegroups.com,
        Dongliang Mu <dzm91@...t.edu.cn>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] usb: dwc3: host: remove dead code in
 dwc3_host_get_irq()



On 23.03.23 15:06, Dan Carpenter wrote:

>> irq != 0
> 
> You've reversed this if statement in your head.  It says that if
> platform_get_irq() returns zero, then return -EINVAL.
> 

Argh. You are right.

	Sorry
		Oliver