linux-kernel - Re: [PATCH 1/1] mcb: Remove requesting memory region to avoid memory overlapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9851e06c-8430-0303-f5c2-ebcb5e38996b@kernel.org>
Date:   Thu, 23 Mar 2023 16:53:12 +0100
From:   Johannes Thumshirn <jth@...nel.org>
To:     Rodríguez Barbarin, José Javier 
        <JoseJavier.Rodriguez@...gon.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     Sanjuán García, Jorge 
        <Jorge.SanjuanGarcia@...gon.com>, "mmoese@...e.de" <mmoese@...e.de>
Subject: Re: [PATCH 1/1] mcb: Remove requesting memory region to avoid memory
 overlapping

On 23.03.23 16:11, Rodríguez Barbarin, José Javier wrote:
> One thing we can do is modify the chameleon_parse_cells prototype to
> return the actual "chameleon table" size instead of the number of cells
> which can have an undetermined size. At the moment, the return value is
> only used for error checking but the number of cells is never used.
>
> After that, we can check the actual "chameleon table" size and
> drop/reallocate if needed.
Hi Javier,

Yeah that sounds reasonable. mcb_bus_add_devices() calls device_attach()
for the respective IP cores, so they individual driver's ->probe() function
shouldn't be called before mcb_bus_add_devices(). So you could shrink
the resource between chameleon_parse_cells() and mcb_add_devices().

Btw, mcb-lpc.c needs the same fix as well.

Byte,
    Johannes