[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMuHMdUF5x=nVMKFFffbbe6S2nGWzq2UZWX36JgyXBGLBVL1rw@mail.gmail.com>
Date: Thu, 23 Mar 2023 17:09:06 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Bjorn Andersson <quic_bjorande@...cinc.com>
Cc: Bhavya Kapoor <b-kapoor@...com>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
catalin.marinas@....com, will@...nel.org,
dmitry.baryshkov@...aro.org, arnd@...db.de,
krzysztof.kozlowski@...aro.org, geert+renesas@...der.be,
nfraprado@...labora.com, broonie@...nel.org, rafal@...ecki.pl
Subject: Re: [PATCH v2] arm64: defconfig: Enable CAN PHY transceiver driver
On Thu, Mar 23, 2023 at 2:53 PM Bjorn Andersson
<quic_bjorande@...cinc.com> wrote:
> On Thu, Mar 23, 2023 at 05:03:24PM +0530, Bhavya Kapoor wrote:
> > Enable CAN PHY transceiver driver to be built as a module.
>
> Please use the commit message to describe why the driver should be
> enabled. The patch and the subject already states clearly that the
> driver is being enabled.
And if no one has inspiration: I wouldn't mind "because it is needed
for CAN-FD on the Renesas White-Hawk development board" ;-)
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -1292,6 +1292,7 @@ CONFIG_RESET_QCOM_PDC=m
> > CONFIG_RESET_RZG2L_USBPHY_CTRL=y
> > CONFIG_RESET_TI_SCI=y
> > CONFIG_PHY_XGENE=y
> > +CONFIG_PHY_CAN_TRANSCEIVER=m
> > CONFIG_PHY_SUN4I_USB=y
> > CONFIG_PHY_CADENCE_TORRENT=m
> > CONFIG_PHY_CADENCE_SIERRA=m
For the actual change:
Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Powered by blists - more mailing lists