linux-kernel - Re: [RFC v2 0/5] remove page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <655ddc1c-8b64-1168-0f6b-76c565363325@samsung.com>
Date:   Thu, 23 Mar 2023 17:16:59 +0100
From:   Pankaj Raghav <p.raghav@...sung.com>
To:     Matthew Wilcox <willy@...radead.org>
CC:     <senozhatsky@...omium.org>, <viro@...iv.linux.org.uk>,
        <axboe@...nel.dk>, <brauner@...nel.org>,
        <akpm@...ux-foundation.org>, <minchan@...nel.org>,
        <hubcap@...ibond.com>, <martin@...ibond.com>, <mcgrof@...nel.org>,
        <devel@...ts.orangefs.org>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>,
        <linux-block@...r.kernel.org>, <gost.dev@...sung.com>
Subject: Re: [RFC v2 0/5] remove page_endio()

>> I also changed mpage to **not set** the error flag in the read path. It does beg
>> the question whether block_read_full_folio() and iomap_finish_folio_read() should
>> also follow the suit.
> 
> Wrong.  mpage is used by filesystems which *DO* check the error flag.
> You can't remove it being set until they're fixed to not check it.
Got it. I think after your explanation on the Error flag, it makes sense why mpage
needs to set the error flag, for now. I will change it as a part of the next version
along with the other comment on Patch 4.