linux-kernel - Re: [PATCH mfd-n 2/2] mfd: rsmu: support 32-bit address space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230323095736.38ea1ca8@kernel.org>
Date:   Thu, 23 Mar 2023 09:57:36 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Min Li <lnimi@...mail.com>
Cc:     richardcochran@...il.com, lee@...nel.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        Min Li <min.li.xe@...esas.com>
Subject: Re: [PATCH mfd-n 2/2] mfd: rsmu: support 32-bit address space

On Thu, 23 Mar 2023 12:15:18 -0400 Min Li wrote:
> -	u8 cmd[256] = {0};
> -	u8 rsp[256] = {0};
> +	u8 cmd[RSMU_MAX_READ_COUNT + 1] = {0};
> +	u8 rsp[RSMU_MAX_READ_COUNT + 1] = {0};
>  	int ret;
>  
> +	if (bytes > RSMU_MAX_READ_COUNT)
> +		return -EINVAL;

Why is defining the constant to MAX_READ and checking the requested
size part of this patch, the commit message only talks about addresses
operation size is not mentioned in any way...