[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZByOLjobQ2TrdFXQ@aschofie-mobl2>
Date: Thu, 23 Mar 2023 10:36:46 -0700
From: Alison Schofield <alison.schofield@...el.com>
To: Sumitra Sharma <sumitraartsy@...il.com>
Cc: outreachy@...ts.linux.dev, johan@...nel.org, elder@...nel.org,
gregkh@...uxfoundation.org, greybus-dev@...ts.linaro.org,
linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] Staging: greybus: Convert macro definitions to
On Thu, Mar 23, 2023 at 02:01:04AM -0700, Sumitra Sharma wrote:
> Convert macros to a static inline function, to make the relevant
> types apparent in the definition and to benefit from the type
> checking performed by the compiler at call sites.
>
> Sumitra Sharma (3):
> Staging: greybus: Convert macro gpio_chip_to_gb_gpio_controller to an
> inline function
> Staging: greybus: Convert macro struct gb_audio_manager_module to an
> inline function
> Staging: greybus: Convert macro struct pwm_chip_to_gb_pwm_chip to an
> inline function
Hi Sumitra,
Please review:
https://kernelnewbies.org/Outreachyfirstpatch#:~:text=Following%20the%20Driver%20commit%20style
That is the section on 'Following the driver commit style'.
Cover letter Subject seems to be needlessly truncated.
Alison
>
> drivers/staging/greybus/audio_manager_module.c | 7 +++++--
> drivers/staging/greybus/gpio.c | 7 +++++--
> drivers/staging/greybus/pwm.c | 6 ++++--
> 3 files changed, 14 insertions(+), 6 deletions(-)
>
> --
> 2.25.1
>
>
Powered by blists - more mailing lists