linux-kernel - Re: [PATCH v3 1/6] pinctrl: s32g2: use of_device_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZByPlYRFxDm/cBCa@linux-8mug>
Date:   Fri, 24 Mar 2023 01:42:45 +0800
From:   Chester Lin <clin@...e.com>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     NXP S32 Linux Team <s32@....com>, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Ghennadi Procopciuc <Ghennadi.Procopciuc@....nxp.com>,
        Andrei Stefanescu <andrei.stefanescu@....com>,
        Radu Pirea <radu-nicolae.pirea@....com>,
        Andreas Färber <afaerber@...e.de>,
        Matthias Brugger <mbrugger@...e.com>
Subject: Re: [PATCH v3 1/6] pinctrl: s32g2: use of_device_get_match_data() to
 get device data

On Fri, Mar 24, 2023 at 01:11:37AM +0800, kernel test robot wrote:
> Hi Chester,
> 
> I love your patch! Perhaps something to improve:
> 
> [auto build test WARNING on linusw-pinctrl/devel]
> [also build test WARNING on linusw-pinctrl/for-next next-20230323]
> [cannot apply to linus/master v6.3-rc3]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Chester-Lin/pinctrl-s32g2-use-of_device_get_match_data-to-get-device-data/20230323-225141
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
> patch link:    https://lore.kernel.org/r/20230323144833.28562-2-clin%40suse.com
> patch subject: [PATCH v3 1/6] pinctrl: s32g2: use of_device_get_match_data() to get device data
> config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20230324/202303240158.uaLsPb4O-lkp@intel.com/config)
> compiler: aarch64-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/intel-lab-lkp/linux/commit/b716f96ba217e92e79b0d888f187ba0f30d705cf
>         git remote add linux-review https://github.com/intel-lab-lkp/linux
>         git fetch --no-tags linux-review Chester-Lin/pinctrl-s32g2-use-of_device_get_match_data-to-get-device-data/20230323-225141
>         git checkout b716f96ba217e92e79b0d888f187ba0f30d705cf
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/pinctrl/nxp/
> 
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@...el.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202303240158.uaLsPb4O-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>    drivers/pinctrl/nxp/pinctrl-s32g2.c: In function 's32g_pinctrl_probe':
> >> drivers/pinctrl/nxp/pinctrl-s32g2.c:747:40: warning: passing argument 2 of 's32_pinctrl_probe' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>      747 |         return s32_pinctrl_probe(pdev, info);
>          |                                        ^~~~
>    In file included from drivers/pinctrl/nxp/pinctrl-s32g2.c:18:
>    drivers/pinctrl/nxp/pinctrl-s32.h:70:54: note: expected 'struct s32_pinctrl_soc_info *' but argument is of type 'const struct s32_pinctrl_soc_info *'
>       70 |                         struct s32_pinctrl_soc_info *info);
>          |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
> 

I will appreciate if someone can give me suggestions. In fact the patch [v3 6/6]
in this series can solve this warning properly rather than casting data type,
should I combine [1/6, changed from v2] and [6/6, new in v3] together since
they are relevant?

Thanks,
Chester

> 
> vim +747 drivers/pinctrl/nxp/pinctrl-s32g2.c
> 
>    740	
>    741	static int s32g_pinctrl_probe(struct platform_device *pdev)
>    742	{
>    743		const struct s32_pinctrl_soc_info *info;
>    744	
>    745		info = of_device_get_match_data(&pdev->dev);
>    746	
>  > 747		return s32_pinctrl_probe(pdev, info);
>    748	}
>    749	
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests