linux-kernel - Re: [PATCH v16 8/8] x86/smpboot: Allow parallel bringup for SEV-ES

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <19ec60aa-fa11-c44e-a6d1-9583f2e7707a@amd.com>
Date:   Thu, 23 Mar 2023 13:28:38 -0500
From:   Tom Lendacky <thomas.lendacky@....com>
To:     "Woodhouse, David" <dwmw@...zon.co.uk>,
        "usama.arif@...edance.com" <usama.arif@...edance.com>,
        "bp@...en8.de" <bp@...en8.de>
Cc:     "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "brgerst@...il.com" <brgerst@...il.com>,
        "arjan@...ux.intel.com" <arjan@...ux.intel.com>,
        "hewenliang4@...wei.com" <hewenliang4@...wei.com>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "simon.evans@...edance.com" <simon.evans@...edance.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "oleksandr@...alenko.name" <oleksandr@...alenko.name>,
        "kim.phillips@....com" <kim.phillips@....com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "fam.zheng@...edance.com" <fam.zheng@...edance.com>,
        "mimoja@...oja.de" <mimoja@...oja.de>,
        "seanjc@...gle.com" <seanjc@...gle.com>,
        "liangma@...ngbit.com" <liangma@...ngbit.com>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "hpa@...or.com" <hpa@...or.com>,
        "punit.agrawal@...edance.com" <punit.agrawal@...edance.com>,
        "pmenzel@...gen.mpg.de" <pmenzel@...gen.mpg.de>,
        "piotrgorski@...hyos.org" <piotrgorski@...hyos.org>,
        "gpiccoli@...lia.com" <gpiccoli@...lia.com>,
        "paulmck@...nel.org" <paulmck@...nel.org>,
        "Rapan, Sabin" <sabrapan@...zon.com>,
        "rcu@...r.kernel.org" <rcu@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>
Subject: Re: [PATCH v16 8/8] x86/smpboot: Allow parallel bringup for SEV-ES

On 3/23/23 10:34, Woodhouse, David wrote:
> On Thu, 2023-03-23 at 08:16 -0500, Tom Lendacky wrote:
>>
>> Maybe call this sev_early_get_cpuid_0b() or such to imply that the MSR
>> protocol is being used and only retrieving / returning edx.
> 
> Or indeed sev_early_get_apicid() since that's what it's actually doing,
> and the caller doesn't care *how*.

Sounds good.

> 
>> Also, since it is a function now and can be used at any point, the current
>> GHCB MSR should be saved on entry and restored on exit.
> 
> Well, I don't know that it should be callable at any point. This is
> only supposed to be called from head_64.S.

I agree. But once it's there, someone somewhere in the future may look and 
go, oh, I can call this. So I think it either needs a nice comment above 
it about how it is currently used/called and what to do if it needs to be 
called from someplace other than head_64.S or the MSR needs to be 
saved/restored.

Thanks,
Tom

> 
> 
> 
> 
> 
> Amazon Development Centre (London) Ltd. Registered in England and Wales with registration number 04543232 with its registered office at 1 Principal Place, Worship Street, London EC2A 2FA, United Kingdom.
> 
> 
>