linux-kernel - Re: [PATCH] tracepoint: Fix CFI failures with tp_stub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <79f7638e-bbeb-d959-6143-c678a8225459@efficios.com>
Date:   Thu, 23 Mar 2023 14:44:02 -0400
From:   Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Mark Rutland <mark.rutland@....com>, linux-kernel@...r.kernel.org,
        mhiramat@...nel.org, "Jose E. Marchesi" <jose.marchesi@...cle.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Sami Tolvanen <samitolvanen@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH] tracepoint: Fix CFI failures with tp_stub_func

On 2023-03-23 14:42, Steven Rostedt wrote:
> On Thu, 23 Mar 2023 14:37:15 -0400
> Mathieu Desnoyers <mathieu.desnoyers@...icios.com> wrote:
> 
>>> Repeated again so Mathieu doesn't have to search for it.
>>>
>>>       [ Note, this version does use undefined compiler behavior (assuming that
>>>         a stub function with no parameters or return, can be called by a location
>>>         that thinks it has parameters but still no return value. Static calls
>>>         do the same thing, so this trick is not without precedent.
>>>
>>>         There's another solution that uses RCU tricks and is more complex, but
>>>         can be an alternative if this solution becomes an issue.
>>>
>>>         Link: https://lore.kernel.org/lkml/20210127170721.58bce7cc@gandalf.local.home/
>>>       ]
>>
>> Ugh. The last thing we need there is more RCU complexity. My brain is still recovering
>> from fixing the last time the introduction of static calls special-cases ended up subtly
>> breaking tracepoints.
> 
> Well, we can go back to your approach with doing the check in the iterator.
> Setting it to 0x1UL I think is what you wanted (to know it's a removed
> function and not a random NULL).
> 
> I could write that up if you want.

I can write the patch and send an RFC, won't take long.

Thanks,

Mathieu

> 
> -- Steve

-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com