linux-kernel - Re: [PATCH] rcu-tasks: Make pr_info() output more clearly in cblist_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48a5bce5-0a06-4d71-b5f0-14dcea059765@paulmck-laptop>
Date:   Thu, 23 Mar 2023 11:56:07 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Zqiang <qiang1.zhang@...el.com>
Cc:     frederic@...nel.org, joel@...lfernandes.org, rcu@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rcu-tasks: Make pr_info() output more clearly in
 cblist_init_generic()

On Thu, Mar 23, 2023 at 12:00:11PM +0800, Zqiang wrote:
> This commit use rtp->name instead of __func__, and output the value
> of rcu_task_cb_adjust in pr_info(), reduced pr_info() calls.
> 
> Signed-off-by: Zqiang <qiang1.zhang@...el.com>

Queued, thank you!

							Thanx, Paul

> ---
>  kernel/rcu/tasks.h | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
> index 397309da3446..0cf958db4e44 100644
> --- a/kernel/rcu/tasks.h
> +++ b/kernel/rcu/tasks.h
> @@ -270,10 +270,8 @@ static void cblist_init_generic(struct rcu_tasks *rtp)
>  	}
>  	raw_spin_unlock_irqrestore(&rtp->cbs_gbl_lock, flags);
>  
> -	if (rcu_task_cb_adjust)
> -		pr_info("%s: Setting adjustable number of callback queues.\n", __func__);
> -
> -	pr_info("%s: Setting shift to %d and lim to %d.\n", __func__, data_race(rtp->percpu_enqueue_shift), data_race(rtp->percpu_enqueue_lim));
> +	pr_info("%s: Setting shift to %d and lim to %d rcu_task_cb_adjust=%d.\n", rtp->name,
> +			data_race(rtp->percpu_enqueue_shift), data_race(rtp->percpu_enqueue_lim), rcu_task_cb_adjust);
>  }
>  
>  // IRQ-work handler that does deferred wakeup for call_rcu_tasks_generic().
> -- 
> 2.25.1
>