linux-kernel - Re: [PATCH] leds: flash: set varaiables mvflash_3,4ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZByswXZdvtaLOT02@duo.ucw.cz>
Date:   Thu, 23 Mar 2023 20:47:13 +0100
From:   Pavel Machek <pavel@....cz>
To:     Tom Rix <trix@...hat.com>
Cc:     lee@...nel.org, quic_fenglinw@...cinc.com,
        linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: flash: set varaiables mvflash_3,4ch_regs
 storage-class-specifier to static

On Fri 2023-03-17 15:13:41, Tom Rix wrote:
> smatch reports
> drivers/leds/flash/leds-qcom-flash.c:103:18: warning:
>   symbol 'mvflash_3ch_regs' was not declared. Should it be static?
> drivers/leds/flash/leds-qcom-flash.c:115:18: warning:
>   symbol 'mvflash_4ch_regs' was not declared. Should it be static?
> 
> These variables are only used in leds-qcom-flash.c,
> so it should be static.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Acked-by: Pavel Machek <pavel@....cz>

BR,
								Pavel
								
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)