[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <7f977c87-c2ba-4897-8d03-dc35ef706f9e@paulmck-laptop>
Date: Thu, 23 Mar 2023 16:49:39 -0700
From: "Paul E. McKenney" <paulmck@...nel.org>
To: Akira Yokosawa <akiyks@...il.com>
Cc: parri.andrea@...il.com, stern@...land.harvard.edu, will@...nel.org,
peterz@...radead.org, boqun.feng@...il.com, npiggin@...il.com,
dhowells@...hat.com, j.alglave@....ac.uk, luc.maranget@...ia.fr,
linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
kernel-team@...a.com, mingo@...nel.org
Subject: Re: [PATCH memory-model scripts 01/31] tools/memory-model: Document
locking corner cases
On Fri, Mar 24, 2023 at 08:30:38AM +0900, Akira Yokosawa wrote:
> On Thu, 23 Mar 2023 11:52:15 -0700, Paul E. McKenney wrote:
> > On Thu, Mar 23, 2023 at 11:52:57AM +0900, Akira Yokosawa wrote:
> >> Hi Paul,
> >>
> >> On Mon, 20 Mar 2023 18:05:19 -0700, Paul E. McKenney wrote:
> >>> Most Linux-kernel uses of locking are straightforward, but there are
> >>> corner-case uses that rely on less well-known aspects of the lock and
> >>> unlock primitives. This commit therefore adds a locking.txt and litmus
> >>> tests in Documentation/litmus-tests/locking to explain these corner-case
> >>> uses.
> >>>
> >>> Signed-off-by: Paul E. McKenney <paulmck@...nel.org>
> >>> ---
> >>> .../litmus-tests/locking/DCL-broken.litmus | 55 +++
> >>> .../litmus-tests/locking/DCL-fixed.litmus | 56 +++
> >>> .../litmus-tests/locking/RM-broken.litmus | 42 +++
> >>> .../litmus-tests/locking/RM-fixed.litmus | 42 +++
> >>> tools/memory-model/Documentation/locking.txt | 320 ++++++++++++++++++
> >>
> >> I think the documentation needs adjustment to cope with Andrea's change
> >> of litmus tests.
> >>
> >> Also, coding style of code snippets taken from litmus tests look somewhat
> >> inconsistent with other snippets taken from MP+... litmus tests:
> >>
> >> - Simple function signature such as "void CPU0(void)".
> >> - No declaration of local variables.
> >> - Indirection level of global variables.
> >> - No "locations" clause
> >>
> >> How about applying the diff below?
> >
> > Good eyes, thank you! I will fold this in with attribution.
>
> Feel free to add
>
> Reviewed-by: Akira Yokosawa <akiyks@...il.com>
Thank you, I will apply on my next full rebase.
Thanx, Paul
Powered by blists - more mailing lists